Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image to digital text page 186821513 #541

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

aaron-plahn
Copy link
Contributor

No description provided.

@aaron-plahn aaron-plahn requested a review from bsellars January 26, 2024 19:25
Copy link
Contributor

@bsellars bsellars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bsellars bsellars force-pushed the add-audio-for-digital-text-title-186801637 branch from 3b3f6ab to 1055374 Compare January 29, 2024 23:41
Base automatically changed from add-audio-for-digital-text-title-186801637 to integration January 31, 2024 17:39
@aaron-plahn aaron-plahn force-pushed the add-image-to-digital-text-page_186821513 branch from b2b2681 to 54232a5 Compare January 31, 2024 17:44
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
9.3% Duplication on New Code

See analysis details on SonarCloud

@aaron-plahn aaron-plahn merged commit c66dfa0 into integration Jan 31, 2024
3 checks passed
@aaron-plahn aaron-plahn deleted the add-image-to-digital-text-page_186821513 branch January 31, 2024 17:56
aaron-plahn added a commit that referenced this pull request Mar 5, 2024
* implement DigitalText.addPhotographToPage

* add handler for PHOTOGRAPH_ADDED_TO_DIGITAL_TEXT_PAGE

* add happy path test ADD_PHOTOGRAPH_TO_DIGITAL_TEXT_PAGE

* add invalid test cases

* add type validation test ADD_PHOTOGRAPH_TO_DIGITAL_TEXT_PAGE

* fix tests for ADD_PHOTOGRAPH_TO_DIGITAL_TEXT_PAGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants