Publish events #623
Merged
Publish events #623
+396
−363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
event-source-command-forms_188754721
to
integration
January 14, 2025 17:52
aaron-plahn
force-pushed
the
publish-events
branch
from
4df555e to
e0e7563
Compare
yaanahuu2
approved these changes
Jan 14, 2025
apps/api/src/domain/models/term/commands/create-term/term-created.event-handler.ts
Outdated
Show resolved
Hide resolved
aaron-plahn
commented
Jan 14, 2025
| ) { | ||
| super(repositoryProvider, idManager); | ||
| super(repositoryProvider, idManager, eventPublisher); |
There was a problem hiding this comment.
Ah, this is unfortunate.
apps/api/src/domain/models/term/commands/create-term/term-created.event-handler.ts
Outdated
Show resolved
Hide resolved
apps/api/src/domain/models/term/commands/create-term/term-created.event-handler.ts
Outdated
Show resolved
Hide resolved
apps/api/src/persistence/database/arango-database-for-collection.ts
Outdated
Show resolved
Hide resolved
| @@ -213,6 +213,7 @@ export class PersistenceModule implements OnApplicationShutdown { | |||
| audioQueryRepositoryProvider, | |||
| termQueryRepositoryProvider, | |||
| queryRepositoryProvider, | |||
| EventModule, | |||
There was a problem hiding this comment.
This is fine for now. We should think about where this belongs in the long run.
apps/api/src/queries/buildViewModelForResource/viewModels/term.view-model.ts
Show resolved
Hide resolved
|
aaron-plahn
commented
Jan 16, 2025
...rc/domain/models/shared/common-commands/publish-resource/resource-published.event-handler.ts
Show resolved
Hide resolved
apps/api/src/domain/models/term/commands/create-term/term-created.event-handler.ts
Show resolved
Hide resolved
apps/api/src/domain/models/term/repositories/arango-term-query-repository.ts
Show resolved
Hide resolved
apps/api/src/queries/term/__snapshots__/term-queries-fetch-many.e2e.spec.ts.snap
Show resolved
Hide resolved
| allowedUserIds: [dummyQueryUserId], | ||
| allowedGroupIds: [], | ||
| }), | ||
| isPublished: false, | ||
| }); | ||
|
|
||
| // TODO Add happy path cases for a prompt term |
There was a problem hiding this comment.
This isn't super important because none of the logic in the query service or controller distinguishes prompt terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.