Skip to content

Commit

Permalink
Update to 1.20.4 (#7)
Browse files Browse the repository at this point in the history
* Updated Gradle Version

* Updated Loom Version

* Updated GradleProperties to 1.21.4

* Updated needed classes to 1.21.4

* Update mod version

---------

Co-authored-by: CPTProgrammer <[email protected]>
  • Loading branch information
Bloemenpot and CPTProgrammer authored Jan 25, 2025
1 parent ed5e4a7 commit a94415e
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 14 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id 'fabric-loom' version '1.5-SNAPSHOT'
id 'fabric-loom' version '1.9-SNAPSHOT'
id 'maven-publish'
}

Expand Down
10 changes: 5 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ org.gradle.parallel=true

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=1.20.4
yarn_mappings=1.20.4+build.3
loader_version=0.15.6
minecraft_version=1.21.4
yarn_mappings=1.21.4+build.8
loader_version=0.16.9

# Mod Properties
mod_version=0.20.3
mod_version=0.21.0
maven_group=cn.revaria.chatplus
archives_base_name=chat-plus

# Dependencies
fabric_version=0.95.1+1.20.4
fabric_version=0.115.0+1.21.4
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
11 changes: 6 additions & 5 deletions src/main/java/cn/revaria/chatplus/mixin/MixinChat.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package cn.revaria.chatplus.mixin;

import net.minecraft.MinecraftVersion;
import net.minecraft.SharedConstants;
import net.minecraft.item.ItemStack;
import net.minecraft.network.ClientConnection;
import net.minecraft.network.message.*;
Expand All @@ -14,6 +13,7 @@
import net.minecraft.server.network.ServerPlayerEntity;
import net.minecraft.text.MutableText;
import net.minecraft.text.Text;
import net.minecraft.util.StringHelper;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
Expand Down Expand Up @@ -44,7 +44,9 @@ public MixinChat(MinecraftServer server, ClientConnection connection, ConnectedC
@Shadow
public ServerPlayerEntity player;

@Shadow protected abstract Optional<LastSeenMessageList> validateMessage(LastSeenMessageList.Acknowledgment acknowledgment);
// @Shadow protected abstract Optional<LastSeenMessageList> validateMessage(LastSeenMessageList.Acknowledgment acknowledgment);

@Shadow protected abstract Optional<LastSeenMessageList> validateAcknowledgment(LastSeenMessageList.Acknowledgment acknowledgment);

@Shadow protected abstract SignedMessage getSignedMessage(ChatMessageC2SPacket packet, LastSeenMessageList lastSeenMessages) throws MessageChain.MessageChainException;

Expand All @@ -61,8 +63,7 @@ public void onChatMessage(ChatMessageC2SPacket packet, CallbackInfo ci) {
if (hasIllegalCharacter(packet.chatMessage())) {
disconnect(Text.translatable("multiplayer.disconnect.illegal_characters"));
} else {
Optional<LastSeenMessageList> optional = this.validateMessage(packet.acknowledgment());
if (optional.isPresent()) {
Optional<LastSeenMessageList> optional = this.validateAcknowledgment(packet.acknowledgment()); if (optional.isPresent()) {
if (!packet.chatMessage().startsWith("/")){

String changedMessage = packet.chatMessage().replace('&', '§');
Expand Down Expand Up @@ -158,7 +159,7 @@ public void onChatMessage(ChatMessageC2SPacket packet, CallbackInfo ci) {

private static boolean hasIllegalCharacter(String message) {
for(int i = 0; i < message.length(); ++i) {
if (!SharedConstants.isValidChar(message.charAt(i))) {
if (!StringHelper.isValidChar(message.charAt(i))) {
return true;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
}
],
"depends": {
"fabricloader": ">=0.14.21",
"minecraft": "~1.20.4",
"fabricloader": ">=0.16.9",
"minecraft": "~1.21.4",
"java": ">=17",
"fabric-api": "*"
},
Expand Down

0 comments on commit a94415e

Please sign in to comment.