Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionaire Refinement - adding advanced UI, formatting changes, restructuring and rewriting questionnaires #37

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

karansoin
Copy link
Contributor

Questionnaire Refinement with Advanced UI and Formatting

♻️ Current situation & Problem

Current UI is not intuitive with imperfect formatting. Questions and answers in the questionnaires are slightly unclear and values associated with each answer currently are not consistent throughout each question and questionnaire (currently sometimes 1 is the best, and sometimes 1 is the worst)

⚙️ Release Notes

  • Making the UI more intuitive with modified formatting and addition of slider in the questionnaires
  • Modified questions and answers in all questionnaires are to make them more clear and to ensure values associated with each answer currently consistent throughout each question and questionnaire

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
New slider features: StanfordBDHG/phoenix#37

✅ Testing

No additional testing, current UI and SwiftLint tests are extensive

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@karansoin karansoin requested a review from Supereg February 29, 2024 03:04
@karansoin karansoin requested a review from YurenSUN March 1, 2024 01:40
Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.39%. Comparing base (8537f47) to head (94a2076).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files          45       45           
  Lines        2069     2069           
=======================================
  Hits          877      877           
  Misses       1192     1192           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8537f47...94a2076. Read the comment docs.

@karansoin karansoin merged commit 80f3e25 into main Mar 1, 2024
7 checks passed
@karansoin karansoin deleted the karanSoin-Questionnaire-finalUpdates branch March 1, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants