KP-9048 Fix reittidemo video not found #5
Conversation
The video file was not found from the specified location on korp2, and the localhost request made from a user's machine has likely never worked. Now the config matches the location of the actual file.
|
@aajarven, that should work as long as the video file is found at I’m also wondering how the localhost can have worked in production Korp. |
|
This looks good, and in a hurry I would have merged to main. But we agreed to be more flexible in testing, so leaving this PR and the branch open. |
|
@mmatthiesencsc, I think it would be nice to have this in the upcoming Korp3, so what is the advantage of not merging? This is such a simple fix that I don’t see any need for changes, unless the actual location of the file is changed. Or would Korp3 (and the future korp-test) correspond to branch |
|
@janiemi This is a misunderstanding, we do want to have this in production. I just kept it "open" for Anni to be able to test a mechanism that makes it possible in the future to use any branch with Ansible. So it is a technicality. As to your "dev" suggestion above, if "dev" means staging, so very close to production, we should consider it, I think. |
|
I have now verified that CSCfi/Kielipankki-korp-ansible#39 is able to install configuration from this branch, so I'm merging this. Thanks for the reviews! For now, we are using master branches when provisioning korp3, so I'd say that the merged PRs are in the right place. |
|
@mmatthiesencsc and @aajarven, thanks for explaining and sorry about the misunderstanding. We could perhaps at some point discuss what kind of a branch policy would be desired, but it may be partly related to the reorganization of the Kielipankki Korp repositories. |
The video file was not found from the specified location on korp2, and the localhost request made from a user's machine has likely never worked anyway. Now the config matches the location of the actual file.