Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated CVE JSON 5 typescript file is missing elements from schema #5

Open
hkong-mitre opened this issue Jun 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@hkong-mitre
Copy link
Collaborator

The src/generated/quicktools/CveRecordV5.ts file is generated by quicktype/quicktools using the official CVE JSON 5 schema. During a PR review, the reviewer noticed that some elements are missing.

Currently (version 0.9 and 1.0), the script does not use most of the generated code. Only CveMetadata is referenced.

The output from the utility reads in the JSON from RSUS, finds the CveMetadata's cveId, and writes the JSON out to the appropriate /cves directory based on that ID. Since the missing elements are not referenced in the utility and is written out verbatim (after prettying), the issue is not affecting the way that the bulk download github action is working.

However, it raises a concern that should be addressed should the utility use more metadata than what is in CveMetadata.

@hkong-mitre hkong-mitre added the bug Something isn't working label Jun 7, 2023
@hkong-mitre hkong-mitre changed the title CVE JSON 5 typescript is missing elements from schema generated CVE JSON 5 typescript file is missing elements from schema Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant