Remove hard-coded taper in lStokesMOST #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated the taper applied between 100-300 m in lStokesMOST. This taper is no longer necessary with the introduction of a variable MLE length scale.
|
Solves ESCOMP/MOM_interface#217 |
mnlevy1981
requested changes
Jan 8, 2025
src/shared/cvmix_kpp.F90
Outdated
| xbeta = xbeta / (300._cvmix_r8-100._cvmix_r8) | ||
| ybeta = (cvmix_one - xbeta*xbeta)**2 | ||
| beta = ybeta * 0.2_cvmix_r8 | ||
| beta = 0.2_cvmix_r8 |
There was a problem hiding this comment.
You set beta=0.2_cvmix_r8 here, and the following line uses it (Vtc = sqrt( beta *3.8409_cvmix_r8 /ws_wstar) /CVmix_kpp_params_in%Ri_crit), but elsewhere in the code you rely on a hard-coded 0.2. E.g. lines 2708 - 2711:
! From LMD 94, Vtc = sqrt(-beta_T/(c_s*eps))/kappa^2
Vtc = sqrt(0.2_cvmix_r8/(cvmix_get_kpp_real('c_s', CVmix_kpp_params_in) * &
cvmix_get_kpp_real('surf_layer_ext', CVmix_kpp_params_in))) / &
(cvmix_get_kpp_real('vonkarman', CVmix_kpp_params_in)**2)2769-2772
! From LMD 94, Vtc = sqrt(-beta_T/(c_s*eps))/kappa^2
Vtc = sqrt(0.2_cvmix_r8/(cvmix_get_kpp_real('c_s', CVmix_kpp_params_in) * &
cvmix_get_kpp_real('surf_layer_ext', CVmix_kpp_params_in))) / &
(cvmix_get_kpp_real('vonkarman', CVmix_kpp_params_in)**2)and a couple other places where beta shows up in the comment but 0.2 is used in the code. We should either remove the beta variable, or use it in all 5 places the comments indicate it belongs
mnlevy1981
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated the taper applied between 100-300 m in lStokesMOST. This taper is no longer necessary with the introduction of a variable MLE length scale.