improve top face hiding heuristic to also check for source blocks

CaffeineMC · Dec 11, 2024 · 6972baf · 6972baf
1 parent baba058
commit 6972baf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/DefaultFluidRenderer.java b/...net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/DefaultFluidRenderer.java
@@ -597,8 +597,8 @@ private boolean isUpFaceExposedByNeighbors(LevelSlice level, BlockPos blockPos,
                 }
 
                 // the face is visible if any of the blocks
-                BlockPos blockPos2 = this.scratchPos.setWithOffset(blockPos, i, yOffset, j);
-                if (!level.getFluidState(blockPos2).getType().isSame(fluid) && !level.getBlockState(blockPos2).isSolidRender()) {
+                BlockPos otherBlockPos = this.scratchPos.setWithOffset(blockPos, i, yOffset, j);
+                if (!(level.getFluidState(otherBlockPos).isSourceOfType(fluid) || level.getBlockState(otherBlockPos).isSolidRender())) {
                     return true;
                 }
             }