fix: don't check entities if it requires iterating too many sections

CaffeineMC · Oct 22, 2023 · cf8d7ad · cf8d7ad
1 parent eeafb59
commit cf8d7ad
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/main/java/me/jellysquid/mods/sodium/client/render/SodiumWorldRenderer.java b/src/main/java/me/jellysquid/mods/sodium/client/render/SodiumWorldRenderer.java
@@ -371,6 +371,8 @@ private static void renderBlockEntity(MatrixStack matrices,
         matrices.pop();
     }
 
+    // the volume of a section multiplied by the number of sections to be checked at most
+    private static final double MAX_ENTITY_CHECK_VOLUME = 16 * 16 * 16 * 15;
 
     /**
      * Returns whether or not the entity intersects with any visible chunks in the graph.
@@ -388,6 +390,12 @@ public boolean isEntityVisible(Entity entity) {
 
         Box box = entity.getVisibilityBoundingBox();
 
+        // bail on very large entities to avoid checking many sections
+        double entityVolume = (box.maxX - box.minX) * (box.maxY - box.minY) * (box.maxZ - box.minZ);
+        if (entityVolume > MAX_ENTITY_CHECK_VOLUME) {
+            return true;
+        }
+
         return this.isBoxVisible(box.minX, box.minY, box.minZ, box.maxX, box.maxY, box.maxZ);
     }