Sort render regions by distance from camera #2133
Conversation
| double dz = cameraPos.z - region.getCenterZ(); | ||
| renderList.setDistanceFromCamera((dx * dx) + (dy * dy) + (dz * dz)); | ||
| } | ||
| this.lists.sort(LIST_DISTANCE_COMPARATOR); |
There was a problem hiding this comment.
it might be faster to use unstableSort here because that can use quicksort which is allocation free. I can't think of a reason for a stable sort to be necessary. ObjectArrayList does a stable sort by default.
There was a problem hiding this comment.
Is this implementation of quicksort O(n) on sorted inputs? I think sort uses timsort which should have that behavior.
There was a problem hiding this comment.
yeah the default Arrays.sort that it uses for stable sort might just be better. The quicksort is kinda hard to read so I'm not sure it'd actually fare better.
src/main/java/me/jellysquid/mods/sodium/client/render/chunk/lists/ChunkRenderList.java
Outdated
Show resolved
Hide resolved
|
The render regions should always be sorted as a matter of how the chunk traversal algorithm works. If that isn't happening, it means the traversal algorithm is broken. I would much rather fix the underlying issue rather than try to workaround it. |
Fixes #2132 by ensuring the list of render regions is always sorted by distance from the camera.