Fall back to non-vertex-specific coloring if mods override color providers #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMS212
approved these changes
Dec 4, 2023
| @Unique | ||
| private final ReferenceSet<Block> overridenBlocks = new ReferenceOpenHashSet<>(); | ||
|
|
||
|
|
| // it means a mod is using custom logic and we need to disable per-vertex coloring | ||
| if (this.blocksToColor.put(block, provider) != null) { | ||
| this.overridenBlocks.add(block); | ||
| SodiumClientMod.logger().info("Block {} had its color provider replaced and will not use per-vertex coloring", Registries.BLOCK.getId(block)); |
There was a problem hiding this comment.
Can we get the name of the provider it's using, maybe?
IMS212
approved these changes
Dec 4, 2023
IMS212
added a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
…tom-resolver Fall back to non-vertex-specific coloring if mods override color providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Sodium color provider registry unconditionally replaces the color providers on blended vanilla blocks (e.g. leaves). That causes mods replacing vanilla color providers to have their changes ignored. To address this, we only replace the color provider if it wasn't already overriden by a mod. The block in question will no longer use per-vertex blending, but the mod's logic will run as it does in vanilla.