Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to disable Sodium checking for RivaTuner #2165

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add a flag to disable Sodium checking for RivaTuner #2165

merged 1 commit into from
Nov 16, 2023

Conversation

Niterux
Copy link
Contributor

@Niterux Niterux commented Nov 16, 2023

I would like to add this flag to Sodium to disable its check to RTSS as I use RTSS along side Minecraft all of the time and I have no issues pertaining to log spam or performance problems.
A picture of Minecraft a long side the client log and RTSS

@MCRcortex
Copy link
Contributor

from what i can tell in the screenshot however is that rivatuner isnt displaying an overlay, drawing the overlay itself is done via legacy opengl calls which is what causes havoc (unless i am missing something and rivatuner is drawing something in minecraft)

@jellysquid3
Copy link
Member

Since we don't really know what conditions will cause the problem, I guess that I am okay with adding a flag. At some point we should consider moving these flags into a separate config file, or something.

@Niterux
Copy link
Contributor Author

Niterux commented Nov 16, 2023

from what i can tell in the screenshot however is that rivatuner isnt displaying an overlay, drawing the overlay itself is done via legacy opengl calls which is what causes havoc (unless i am missing something and rivatuner is drawing something in minecraft)

Here, I have enabled the overlay
rtsswithoverlay

@jellysquid3 jellysquid3 merged commit 1c7ec04 into CaffeineMC:dev Nov 16, 2023
1 check passed
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants