Fix compiler warnings #2687
Closed
Fix compiler warnings #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common project includes Sodium's Fabric API integration, which can be used on either loader. The Fabric API modules reference Fabric Loader's API classes, so we need to include it to prevent warning spam about an unknown enum constant.
mrmangohands
force-pushed
the
patch/fix-compiler-warnings
branch
2 times, most recently
from
b018a4a to
6bb29b5
Compare
mrmangohands
force-pushed
the
patch/fix-compiler-warnings
branch
from
6bb29b5 to
783b4db
Compare
jellysquid3
requested changes
Aug 17, 2024
...emc/mods/sodium/neoforge/mixin/features/options/render_layers/ItemBlockRenderTypesMixin.java
Show resolved
Hide resolved
...java/net/caffeinemc/mods/sodium/neoforge/mixin/workarounds/context_creation/WindowMixin.java
Show resolved
Hide resolved
...ain/java/net/caffeinemc/mods/sodium/neoforge/mixin/core/render/world/LevelRendererMixin.java
Outdated
Show resolved
Hide resolved
mrmangohands
force-pushed
the
patch/fix-compiler-warnings
branch
from
b5c2bfd to
783b4db
Compare
|
Have the review concerns been resolved? Also this needs to have its conflicts resolved |
|
Resolved with dc7dc4c. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common project includes Sodium's Fabric API integration, which can be used on either loader. The Fabric API modules reference Fabric Loader's API classes, so we need to include it to prevent warning spam about an unknown enum constant.
This PR also splits out the remaining platform specific code from common, and adds
remap = falsewhere necessary to fix warnings.