Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Snowflake support - statement #127

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Conversation

oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Oct 28, 2022

Description

Add snowflake data source and update the document.

Document: https://vulcan-sql-document-git-feature-ds-s-618000-vulcan-sql-document.vercel.app/docs/connectors/snowflake

Issue ticket number

closes #58

Additional Context

The official SDK prints logs with console and files, which should be avoided. #126

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vulcan-sql-document ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 8:09AM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 93.28% // Head: 92.75% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (649d7d0) compared to base (f7de48f).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #127      +/-   ##
===========================================
- Coverage    93.28%   92.75%   -0.54%     
===========================================
  Files          258      270      +12     
  Lines         3740     4045     +305     
  Branches       516      529      +13     
===========================================
+ Hits          3489     3752     +263     
- Misses         171      198      +27     
- Partials        80       95      +15     
Flag Coverage Δ
extension-driver-snowflake 94.59% <94.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xtension-driver-duckdb/src/lib/duckdbDataSource.ts 100.00% <ø> (ø)
...on-driver-snowflake/src/lib/snowflakeDataSource.ts 90.47% <90.47%> (ø)
.../src/lib/artifact-builder/vulcanArtifactBuilder.ts 94.11% <100.00%> (ø)
packages/core/src/lib/validators/constraints.ts 96.66% <100.00%> (ø)
packages/core/src/models/artifact.ts 100.00% <100.00%> (ø)
...ckages/extension-driver-pg/src/lib/pgDataSource.ts 93.44% <100.00%> (+1.25%) ⬆️
packages/extension-driver-snowflake/src/index.ts 100.00% <100.00%> (ø)
...s/extension-driver-snowflake/src/lib/sqlBuilder.ts 100.00% <100.00%> (ø)
...s/extension-driver-snowflake/src/lib/typeMapper.ts 100.00% <100.00%> (ø)
...extension-driver-snowflake/test/snowflakeServer.ts 100.00% <100.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscar60310 oscar60310 marked this pull request as ready for review October 28, 2022 08:03
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@kokokuo kokokuo merged commit 120eec7 into develop Nov 2, 2022
@hanshino hanshino deleted the feature/ds-snowflake branch January 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New driver: Snowflake - statement
3 participants