Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: BigQuery support - statement #131

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Conversation

JSYOU
Copy link
Contributor

@JSYOU JSYOU commented Nov 1, 2022

Description

Add bigquery data source and update the document.

Document:
https://vulcan-sql-document-git-feature-ds-bigquery-vulcan-sql-document.vercel.app/docs/connectors/bigquery

Issue ticket number

closes #57

Additional Context

The official SDK prints logs with console and files, which should be avoided. #126

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vulcan-sql-document ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 5:57AM (UTC)

@JSYOU JSYOU force-pushed the feature/ds-bigquery branch from e757fe2 to 2c58dc0 Compare November 2, 2022 10:27
@JSYOU JSYOU marked this pull request as ready for review November 2, 2022 10:28
@JSYOU JSYOU changed the title [WIP] Feature: BigQuery support - statement Feature: BigQuery support - statement Nov 2, 2022
Copy link
Contributor

@oscar60310 oscar60310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks 👍

packages/extension-driver-bq/package.json Outdated Show resolved Hide resolved
packages/extension-driver-bq/project.json Outdated Show resolved Hide resolved
packages/extension-driver-bq/src/lib/bqDataSource.ts Outdated Show resolved Hide resolved
packages/extension-driver-bq/src/lib/bqDataSource.ts Outdated Show resolved Hide resolved
packages/extension-driver-bq/src/lib/bqDataSource.ts Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 93.02% // Head: 92.81% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (90d145c) compared to base (120eec7).
Patch coverage: 85.21% of modified lines in pull request are covered.

❗ Current head 90d145c differs from pull request most recent head 7d80cce. Consider uploading reports for the commit 7d80cce to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
- Coverage    93.02%   92.81%   -0.22%     
===========================================
  Files          275      280       +5     
  Lines         4157     4272     +115     
  Branches       548      568      +20     
===========================================
+ Hits          3867     3965      +98     
- Misses         192      200       +8     
- Partials        98      107       +9     
Flag Coverage Δ
build 95.18% <ø> (ø)
cli 89.38% <ø> (ø)
core 93.66% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-bq 85.21% <85.21%> (?)
extension-driver-duckdb 100.00% <ø> (ø)
extension-driver-pg 96.11% <ø> (ø)
extension-driver-snowflake 94.59% <ø> (ø)
integration-testing 96.15% <ø> (ø)
serve 90.03% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension-driver-bq/test/bqServer.ts 75.00% <75.00%> (ø)
...ckages/extension-driver-bq/src/lib/bqDataSource.ts 76.19% <76.19%> (ø)
packages/extension-driver-bq/src/lib/typeMapper.ts 95.65% <95.65%> (ø)
packages/extension-driver-bq/src/index.ts 100.00% <100.00%> (ø)
...kages/extension-driver-bq/src/lib/bqlSqlBuilder.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 34 to 46
"publish": {
"executor": "@nrwl/workspace:run-commands",
"options": {
"command": "node tools/scripts/publish.mjs extension-driver-bq {args.ver} {args.tag}",
"cwd": "dist/packages/extension-driver-bq"
},
"dependsOn": [
{
"projects": "self",
"target": "build"
}
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish target should be updated too~

packages/doc/docs/connectors.mdx Outdated Show resolved Hide resolved
packages/doc/docs/connectors/bigquery.mdx Outdated Show resolved Hide resolved
@oscar60310 oscar60310 merged commit 642aeb7 into develop Nov 3, 2022
@oscar60310 oscar60310 deleted the feature/ds-bigquery branch November 3, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New driver: BigQuery - statement
3 participants