Delete all widgets after their usage

This can be really useful to save memory
CapibaraZero · Sep 9, 2024 · 8b381e0 · 8b381e0
1 parent 8db758b
commit 8b381e0
Show file tree

Hide file tree

Showing 33 changed files with 156 additions and 33 deletions.
diff --git a/lib/UI/pages/BLE/BLEPage.cpp b/lib/UI/pages/BLE/BLEPage.cpp
@@ -22,7 +22,14 @@
 #include "../../navigation/BLE/ble_navigation.hpp"
 #include "gui.hpp"
 
-BLEPage::~BLEPage() {}
+BLEPage::~BLEPage() {
+    delete ble_sniff;
+    delete apple_juice;
+    delete samsung_ble;
+    delete swift_pair;
+    delete fast_pair;
+    delete go_back;
+}
 
 void BLEPage::display() {
     init_ble_navigation(gui);

diff --git a/lib/UI/pages/BLE/BLEScanPage.cpp b/lib/UI/pages/BLE/BLEScanPage.cpp
@@ -21,7 +21,11 @@
 #include "../../i18n/BLE/ble_scan_keys.h"
 #include "gui.hpp"
 
-BLEScanPage::~BLEScanPage() {}
+BLEScanPage::~BLEScanPage() {
+  delete ble_scan_adv_devices;
+  delete ble_scan_progress;
+  delete ble_scan_text;
+}
 
 void BLEScanPage::display() {
   grid = new Grid(screen, 3, 1);

diff --git a/lib/UI/pages/BLE/BLESniffPage.cpp b/lib/UI/pages/BLE/BLESniffPage.cpp
@@ -22,7 +22,11 @@
 #include "../../navigation/BLE/ble_navigation.hpp"
 #include "gui.hpp"
 
-BLESniffPage::~BLESniffPage() {}
+BLESniffPage::~BLESniffPage() {
+  delete text;
+  delete packet_count;
+  delete save;
+}
 
 void BLESniffPage::display() {
     text = new Text(screen, ST77XX_WHITE,

diff --git a/lib/UI/pages/BLE/BLESpamPage.cpp b/lib/UI/pages/BLE/BLESpamPage.cpp
@@ -22,7 +22,10 @@
 #include "../../navigation/BLE/ble_navigation.hpp"
 #include "gui.hpp"
 
-BLESpamPage::~BLESpamPage() {}
+BLESpamPage::~BLESpamPage() {
+    delete text;
+    delete save;
+}
 
 void BLESpamPage::display() {
     text = new Text(screen, ST77XX_WHITE,

diff --git a/lib/UI/pages/FileBrowser/FileBrowserPage.cpp b/lib/UI/pages/FileBrowser/FileBrowserPage.cpp
@@ -25,7 +25,6 @@
 #include "gui.hpp"
 
 FileBrowserPage::~FileBrowserPage() {
-    delete grid;
     delete title;
 }
 

diff --git a/lib/UI/pages/IR/IREmulateRC.cpp b/lib/UI/pages/IR/IREmulateRC.cpp
@@ -2,6 +2,10 @@
 #include "style.h"
 #include "../../navigation/IR/IRNavigation.hpp"
 
+IREmulateRC::~IREmulateRC() {
+    delete go_back;
+}
+
 void IREmulateRC::display(const char* cmd[], size_t count)
 {
     grid = new Grid(screen, 2, 4);

diff --git a/lib/UI/pages/IR/IREmulateRC.hpp b/lib/UI/pages/IR/IREmulateRC.hpp
@@ -31,7 +31,7 @@ class IREmulateRC : public Page {
  public:
   IREmulateRC(uint8_t _position_limit, uint8_t _lower_limit,
          uint8_t _position_increment, GFXForms *screen, Gui *_gui) : Page(_position_limit, _lower_limit, _position_increment, screen, _gui) {};
-  ~IREmulateRC() {};
+  ~IREmulateRC();
   void display(const char* cmd[], size_t count);
   void display();
   void set_selected(int pos, bool status) {

diff --git a/lib/UI/pages/IR/IRListsProgress.cpp b/lib/UI/pages/IR/IRListsProgress.cpp
@@ -2,6 +2,11 @@
 #include "style.h"
 #include "../../navigation/IR/IRNavigation.hpp"
 
+IRListsProgress::~IRListsProgress() {
+    delete progress;
+    delete stop;
+}
+
 void IRListsProgress::display()
 {
 

diff --git a/lib/UI/pages/IR/IRListsProgress.hpp b/lib/UI/pages/IR/IRListsProgress.hpp
@@ -32,7 +32,7 @@ class IRListsProgress : public Page {
  public:
   IRListsProgress(uint8_t _position_limit, uint8_t _lower_limit,
          uint8_t _position_increment, GFXForms *screen, Gui *_gui) : Page(_position_limit, _lower_limit, _position_increment, screen, _gui) {};
-  ~IRListsProgress() {};
+  ~IRListsProgress();
   void display();
   void set_selected(int pos, bool status) {
     grid->set_selected(pos, status);

diff --git a/lib/UI/pages/IR/IRMainPage.cpp b/lib/UI/pages/IR/IRMainPage.cpp
@@ -22,10 +22,11 @@
 #include "../../navigation/IR/IRNavigation.hpp"
 #include "gui.hpp"
 
-IRMainPage::~IRMainPage() {}
-
-void mock() {
-
+IRMainPage::~IRMainPage() {
+  delete record_signal;
+  delete emulate_signal;
+  delete emulate_rc;
+  delete go_back;
 }
 
 void IRMainPage::display() {

diff --git a/lib/UI/pages/IR/IRRecordSignalPage.cpp b/lib/UI/pages/IR/IRRecordSignalPage.cpp
@@ -24,7 +24,8 @@
 
 IRRecordSignalPage::~IRRecordSignalPage() {
         Serial.println("Destroy");
-
+  delete protocol;
+  delete stop;
 }
 
 void IRRecordSignalPage::display() {

diff --git a/lib/UI/pages/NFC/NFCBruteforceTagPage.cpp b/lib/UI/pages/NFC/NFCBruteforceTagPage.cpp
@@ -21,7 +21,11 @@
 #include "../../navigation/NFC/NFCNavigation.hpp"
 #include "gui.hpp"
 
-NFCBruteforceTagPage::~NFCBruteforceTagPage() {}
+NFCBruteforceTagPage::~NFCBruteforceTagPage() {
+  delete bruteforce_info;
+  delete tried_keys;
+  delete found_keys;
+}
 
 void NFCBruteforceTagPage::display() {
   grid = new Grid(screen, 3, 1);

diff --git a/lib/UI/pages/NFC/NFCDumpResultPage.cpp b/lib/UI/pages/NFC/NFCDumpResultPage.cpp
@@ -19,7 +19,13 @@
 #include "../../navigation/NFC/NFCNavigation.hpp"
 #include "gui.hpp"
 
-NFCDumpResultPage::~NFCDumpResultPage() {}
+NFCDumpResultPage::~NFCDumpResultPage() {
+    delete dumping_to_sd;
+    delete dumped_sectors;
+    delete unreadable_sectors;
+    delete unauthenticated_sectors;
+    delete save_to_sd;
+}
 
 void NFCDumpResultPage::display() {
   grid = new Grid(screen, 6, 1);

diff --git a/lib/UI/pages/NFC/NFCFormatResultPage.cpp b/lib/UI/pages/NFC/NFCFormatResultPage.cpp
@@ -18,7 +18,11 @@
 #include "NFCFormatResultPage.hpp"
 #include "gui.hpp"
 
-NFCFormatResultPage::~NFCFormatResultPage() {}
+NFCFormatResultPage::~NFCFormatResultPage() {
+  delete dumping_to_sd;
+  delete formatted_sectors;
+  delete unauthenticated_sectors;
+}
 
 void NFCFormatResultPage::display() {
   grid = new Grid(screen, 3, 1);

diff --git a/lib/UI/pages/NFC/NFCMainPage.cpp b/lib/UI/pages/NFC/NFCMainPage.cpp
@@ -22,7 +22,11 @@
 #include "../../navigation/NFC/NFCNavigation.hpp"
 #include "gui.hpp"
 
-NFCMainPage::~NFCMainPage() {}
+NFCMainPage::~NFCMainPage() {
+  delete polling_iso14443_a;
+  delete polling_felica;
+  delete go_back;
+}
 
 void NFCMainPage::display() {
   init_nfc_navigation(gui);

diff --git a/lib/UI/pages/NFC/NFCPollingResultPage.cpp b/lib/UI/pages/NFC/NFCPollingResultPage.cpp
@@ -23,7 +23,12 @@
 #include "../../navigation/NFC/NFCNavigation.hpp"
 #include "gui.hpp"
 
-NFCPollingResultPage::~NFCPollingResultPage() {}
+NFCPollingResultPage::~NFCPollingResultPage() {
+  delete tag_info;
+  delete uid_text;
+  delete bruteforce_tag;
+  delete exit_page;
+}
 
 void NFCPollingResultPage::display(uint8_t *uid, uint8_t length, const char *tag_name) {
   grid = new Grid(screen, 4, 1);

diff --git a/lib/UI/pages/NFC/NFCPollingWaitingPage.cpp b/lib/UI/pages/NFC/NFCPollingWaitingPage.cpp
@@ -22,7 +22,11 @@
 #include "../../navigation/NFC/NFCNavigation.hpp"
 #include "gui.hpp"
 
-NFCPollingWaitingPage::~NFCPollingWaitingPage() {}
+NFCPollingWaitingPage::~NFCPollingWaitingPage() {
+  delete polling_in_progress;
+  delete info_msg;
+  delete go_back;
+}
 
 void NFCPollingWaitingPage::display() {
   grid = new Grid(screen, 2, 1);

diff --git a/lib/UI/pages/NFC/NFCWriteResultPage.cpp b/lib/UI/pages/NFC/NFCWriteResultPage.cpp
@@ -21,7 +21,11 @@
 #include "../../i18n/BLE/BLE_submenu_keys.h"
 #include "gui.hpp"
 
-NFCWriteResultPage::~NFCWriteResultPage() {}
+NFCWriteResultPage::~NFCWriteResultPage() {
+  delete write_info;
+  delete wrote_sectors;
+  delete unwritable_sectors;
+}
 
 void NFCWriteResultPage::display() {
   grid = new Grid(screen, 4, 1);

diff --git a/lib/UI/pages/Page.hpp b/lib/UI/pages/Page.hpp
@@ -44,6 +44,9 @@ class Page {
     }
 
    public:
+    virtual ~Page() {
+        delete grid;
+    }
     virtual void display() = 0;
     virtual void up() {
         if(position_increment == 0)

diff --git a/lib/UI/pages/SubGHZ/SubGHZFrequencyAnalyzerPage.cpp b/lib/UI/pages/SubGHZ/SubGHZFrequencyAnalyzerPage.cpp
@@ -20,7 +20,11 @@
 #include "../../i18n.hpp"
 #include "gui.hpp"
 
-SubGHZFrequencyAnalyzerPage::~SubGHZFrequencyAnalyzerPage() {}
+SubGHZFrequencyAnalyzerPage::~SubGHZFrequencyAnalyzerPage() {
+    delete current_frequency;
+    delete current_rssi;
+    delete stop;
+}
 
 void SubGHZFrequencyAnalyzerPage::display() {
     grid = new Grid(screen, 3, 1);

diff --git a/lib/UI/pages/SubGHZ/SubGHZPage.cpp b/lib/UI/pages/SubGHZ/SubGHZPage.cpp
@@ -21,7 +21,12 @@
 #include "../../navigation/SubGHZ/SubGHZNavigation.hpp"
 #include "gui.hpp"
 
-SubGHZPage::~SubGHZPage() {}
+SubGHZPage::~SubGHZPage() {
+    delete SubGHZ_freq_analyzer;
+    delete SubGHZ_sniff;
+    delete SubGHZ_sender;
+    delete go_back;
+}
 
 void SubGHZPage::display() {
     init_subghz_navigation(gui);

diff --git a/lib/UI/pages/SubGHZ/SubGHZRAWRecordPage.cpp b/lib/UI/pages/SubGHZ/SubGHZRAWRecordPage.cpp
@@ -21,7 +21,12 @@
 #include "../../navigation/SubGHZ/SubGHZNavigation.hpp"
 #include "gui.hpp"
 
-SubGHZRAWRecordPage::~SubGHZRAWRecordPage() {}
+SubGHZRAWRecordPage::~SubGHZRAWRecordPage() {
+    delete current_frequency;
+    delete current_rssi;
+    delete current_lqi;
+    delete stop;
+}
 
 void SubGHZRAWRecordPage::display() {
  grid = new Grid(screen, 3, 1);

diff --git a/lib/UI/pages/SubGHZ/SubGHZSender.cpp b/lib/UI/pages/SubGHZ/SubGHZSender.cpp
@@ -21,7 +21,12 @@
 #include "../../i18n.hpp"
 #include "gui.hpp"
 
-SubGHZSender::~SubGHZSender() {}
+SubGHZSender::~SubGHZSender() {
+    delete current_frequency;
+    delete current_modulation;
+    delete current_bw;
+    delete current_deviation;
+}
 
 void SubGHZSender::display() {
     grid = new Grid(screen, 4, 1);

diff --git a/lib/UI/pages/main_page/MainPage.cpp b/lib/UI/pages/main_page/MainPage.cpp
@@ -27,7 +27,9 @@
 #include "style.h"
 #include "battery_monitor.hpp"
 
-MainPage::~MainPage() {}
+MainPage::~MainPage() {
+    // MainPage never get destroyed
+}
 
 void section_not_ready() { LOG_ERROR("Section not ready"); }
 void MainPage::display() {

diff --git a/lib/UI/pages/network_attacks/ARPoisonerPage.cpp b/lib/UI/pages/network_attacks/ARPoisonerPage.cpp
@@ -22,7 +22,10 @@
 #include "../../navigation/network_attacks/network_attacks_navigation.hpp"
 #include "gui.hpp"
 
-ARPoisonerPage::~ARPoisonerPage() {}
+ARPoisonerPage::~ARPoisonerPage() {
+    delete text;
+    delete stop;
+}
 
 void ARPoisonerPage::display() {
     grid = new Grid(screen, 2, 1);

diff --git a/lib/UI/pages/network_attacks/DHCPGluttonPage.cpp b/lib/UI/pages/network_attacks/DHCPGluttonPage.cpp
@@ -22,7 +22,11 @@
 #include "../../navigation/network_attacks/network_attacks_navigation.hpp"
 #include "gui.hpp"
 
-DHCPGluttonPage::~DHCPGluttonPage() {}
+DHCPGluttonPage::~DHCPGluttonPage() {
+  delete text;
+  delete client_count;
+  delete save;
+}
 
 void DHCPGluttonPage::update_packet_count(int count) {
   client_count->set_text(english_words->at(CREATED_DHCPGLUTTON_CLIENTS_KEY) +

diff --git a/lib/UI/pages/network_attacks/EvilPortalPage.cpp b/lib/UI/pages/network_attacks/EvilPortalPage.cpp
@@ -22,7 +22,12 @@
 #include "../../navigation/network_attacks/network_attacks_navigation.hpp"
 #include "gui.hpp"
 
-EvilPortalPage::~EvilPortalPage() {}
+EvilPortalPage::~EvilPortalPage() {
+  delete text;
+  delete portal_ip;
+  delete client_count;
+  delete save;
+}
 
 void EvilPortalPage::update_requests_count(int count) {
   client_count->set_text(english_words->at(EVILPORTAL_CAPTURED_REQUESTS_KEY) +

diff --git a/lib/UI/pages/network_attacks/NetworkAttacksPage.cpp b/lib/UI/pages/network_attacks/NetworkAttacksPage.cpp
@@ -22,7 +22,12 @@
 #include "../../navigation/network_attacks/network_attacks_navigation.hpp"
 #include "gui.hpp"
 
-NetworkAttacksPage::~NetworkAttacksPage() {}
+NetworkAttacksPage::~NetworkAttacksPage() {
+  delete evilportal;
+  delete dhcpglutton;
+  delete arp_poisoner;
+  delete go_back;
+}
 
 void NetworkAttacksPage::display() {
   init_network_attacks_navigation(gui);

diff --git a/lib/UI/pages/wifi/WifiNetworksPage.cpp b/lib/UI/pages/wifi/WifiNetworksPage.cpp
@@ -21,7 +21,13 @@
 #include "../../i18n/wifi/wifi_network_details_keys.h"
 #include "gui.hpp"
 
-WifiNetworksPage::~WifiNetworksPage() {}
+WifiNetworksPage::~WifiNetworksPage() {
+  delete ssid;
+  delete rssi;
+  delete bssid;
+  delete ch;
+  delete auth;
+}
 
 void WifiNetworksPage::set_network() {
   if(networks->size() == 0) {

diff --git a/lib/UI/pages/wifi/WifiPage.cpp b/lib/UI/pages/wifi/WifiPage.cpp
@@ -22,7 +22,11 @@
 #include "../../navigation/wifi/wifi_navigation.hpp"
 #include "gui.hpp"
 
-WifiPage::~WifiPage() {}
+WifiPage::~WifiPage() {
+  delete wifi_list;
+  delete wifi_sniff;
+  delete go_back;
+}
 
 void WifiPage::display() {
   init_wifi_navigation(gui);

diff --git a/lib/UI/pages/wifi/WifiScanPage.cpp b/lib/UI/pages/wifi/WifiScanPage.cpp
@@ -21,7 +21,11 @@
 #include "../../i18n/wifi/wifi_scan_keys.h"
 #include "gui.hpp"
 
-WifiScanPage::~WifiScanPage() {}
+WifiScanPage::~WifiScanPage() {
+  delete wifi_scan_text;
+  delete wifi_scan_progress;
+  delete wifi_scan_current_ch;
+}
 
 void WifiScanPage::display() {
   grid = new Grid(screen, 3, 1);