Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-step ownership transfer #26

Merged
merged 3 commits into from
Jul 9, 2024
Merged

2-step ownership transfer #26

merged 3 commits into from
Jul 9, 2024

Conversation

JanKuczma
Copy link
Collaborator

@JanKuczma JanKuczma commented Jul 8, 2024

Currently, the owner of the contract has the privilege to change several crucial parameters of the pool contract.

This PR is one of the solutions to increase the security of the protocol. See other solution #27

Allow 2-step process of the ownership transfer to increase the security of the protocol.
Ideally, the owner role will be controlled by a multisig account to increase the decentralization of the power.

@JanKuczma JanKuczma mentioned this pull request Jul 8, 2024
@JanKuczma JanKuczma requested a review from DamianStraszak July 9, 2024 08:01
Copy link
Contributor

@DamianStraszak DamianStraszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one, would be great to have the option of renouncing ownership though.

@JanKuczma JanKuczma merged commit b43fc14 into main Jul 9, 2024
1 check passed
@JanKuczma JanKuczma deleted the ownable2step branch July 9, 2024 10:55
Copy link
Contributor

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have test for this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants