Test try withdrawing too much #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try exploiting the contract by adding large liquidity, and then split the withdrawal into ~100 smaller withdrawals, hoping that rounding errors when computing the LPT to burn will burn not enough tokens, and that after withdrawing the whole added amount, there will still be some small amount of LPT to use for another withdrawal.
Test passed - no exploit succeeded.
Note
Also observed: If we increase the burned shares by 1, as in curve.fi, the user is not able to withdraw the whole deposited amount. Some tiny amount of them will be locked forever.