Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer: permissible ERC20 tokens #99

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Conversation

pmikolajczyk41
Copy link
Member

  1. Add a configuration parameter to specify which ERC20 tokens are supported as payment tokens.
  2. Add a parameter to the RelayQuery and validate it.

@pmikolajczyk41 pmikolajczyk41 requested a review from kroist January 30, 2025 06:53
Copy link

github-actions bot commented Jan 30, 2025

Transaction NameMainCurrentDifference (%)
NewAccountNative20003232000371+0.00240%
DepositNative18279181827906-0.00066%
WithdrawNative18981621898138-0.00126%

Copy link

github-actions bot commented Jan 30, 2025

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 2008 2235 🟡 89.84%
📄 Statements 2008 2235 🟡 89.84%
⚡ Functions 69 76 🟡 90.78%
🔀 Branches 197 199 🟡 98.99%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
zkOS-monorepo/ts/shielder-sdk/src/_generated/abi.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/index.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 9.09% 9.09% 25% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 20.75% 20.75% 33.33% 50%
zkOS-monorepo/ts/shielder-sdk/src/client.ts 100% 100% 93.75% 100%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/state/events.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/index.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/manager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/storageSchema.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

crates/shielder-relayer/src/config/cli.rs Outdated Show resolved Hide resolved
@kroist
Copy link
Collaborator

kroist commented Jan 30, 2025

To be aligned:

The relayer would generally accept any whitelisted token as a withdraw fee re-payment? And this re-payment correctness logic would be inside the smart contract raw call, correct?

@pmikolajczyk41 pmikolajczyk41 merged commit 3530dab into main Jan 30, 2025
9 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the relayer-permissible-tokens branch January 30, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants