Skip to content

Commit

Permalink
Add logLevel option to the Helm chart values
Browse files Browse the repository at this point in the history
  • Loading branch information
moicalcob committed Dec 11, 2024
1 parent 280aedd commit 3bcd0e9
Show file tree
Hide file tree
Showing 13 changed files with 53 additions and 48 deletions.
11 changes: 11 additions & 0 deletions chart/templates/_validators.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,24 @@ If internalPostgresql.enabled=false you need to specify the host of an external
{{- end -}}
{{- end -}}

{{/*
Validate log level
*/}}
{{- define "carto.validateValues.logLevel" -}}
{{- $validLevels := list "info" "debug" "error" -}}
{{- if not (has $validLevels .Values.appConfigValues.logLevel) -}}
{{- printf "Invalid logLevel: %s. Must be one of %v" .Values.appConfigValues.logLevel $validLevels -}}
{{- end -}}
{{- end -}}

{{/*
Compile all warnings into a single message, and call fail.
*/}}
{{- define "carto.validateValues" -}}
{{- $messages := list -}}
{{- $messages := append $messages (include "carto.validateValues.redis" .) -}}
{{- $messages := append $messages (include "carto.validateValues.postgresql" .) -}}
{{- $messages := append $messages (include "carto.validateValues.logLevel" .) -}}
{{- $messages := without $messages "" -}}
{{- $message := join "\n" $messages -}}

Expand Down
2 changes: 1 addition & 1 deletion chart/templates/accounts-www/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ metadata:
data:
CARTO_DATA_WAREHOUSE_ENABLED: {{ .Values.cartoConfigValues.cartoDataWarehouseEnabled | quote }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
PORT: {{ .Values.accountsWww.containerPorts.http | quote }}
REACT_APP_ACCOUNTS_API_URL: "https://{{ .Values.cartoConfigValues.cartoAccApiDomain }}"
REACT_APP_ACCOUNTS_URL: "https://{{ .Values.appConfigValues.selfHostedDomain }}/acc/"
Expand Down
1 change: 1 addition & 0 deletions chart/templates/http-cache/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ data:
VARNISH_WORKSPACE_API_INTERNAL_URL: {{ include "carto.workspaceApi.fullname" . }}.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}
VARNISH_PURGE_ALLOWED_IPS: "0.0.0.0/0"
VARNISH_REPORT_BASIC_INFORMATION_HEADERS: "true"
VARNISH_LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
{{- if .Values.httpCache.resources.requests }}
{{- if .Values.httpCache.resources.requests.memory }}
VARNISH_SIZE: {{ ( div ( mul ( ( .Values.httpCache.resources.requests.memory ) | replace "Mi" "" | atoi ) 75 ) 100 ) | toString | printf "%sM" | quote }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/import-api/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@ data:
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
IMPORT_ERROR_RESPONSE_STACK_TRACE: {{ .Values.cartoConfigValues.enableErrorResponseStackTrace | quote }}
IMPORT_PORT: {{ .Values.importApi.containerPorts.http | quote }}
IMPORT_PUBSUB_TENANT_BUS_SUBSCRIPTION: "projects/{{ .Values.cartoConfigValues.selfHostedGcpProjectId }}/subscriptions/tenant-bus-import-sub"
IMPORT_PUBSUB_TENANT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.selfHostedGcpProjectId }}/topics/tenant-bus"
IMPORT_TENANT_ID: {{ .Values.cartoConfigValues.selfHostedTenantId | quote }}
IMPORT_WORKER_PROCESSING_DIR: "/tmp/import-worker"
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
PUBSUB_PROJECT_ID: {{ .Values.cartoConfigValues.selfHostedGcpProjectId | quote }}
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/import-worker/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ data:
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
GOOGLE_APPLICATION_CREDENTIALS: {{ include "carto.google.secretMountAbsolutePath" . }}
{{- end }}
Expand All @@ -25,7 +28,7 @@ data:
IMPORT_PUBSUB_TENANT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.selfHostedGcpProjectId }}/topics/tenant-bus"
IMPORT_TENANT_ID: {{ .Values.cartoConfigValues.selfHostedTenantId | quote }}
IMPORT_WORKER_PROCESSING_DIR: "/tmp/import-worker"
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
NODE_OPTIONS: {{ template "carto.importWorker.nodeOptions" . }}
PUBSUB_PROJECT_ID: {{ .Values.cartoConfigValues.selfHostedGcpProjectId | quote }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/lds-api/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,17 @@ data:
AUTH0_DOMAIN: {{ .Values.cartoConfigValues.cartoAuth0CustomDomain | quote }}
AUTH0_NAMESPACE: "http://app.carto.com"
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
GOOGLE_APPLICATION_CREDENTIALS: {{ include "carto.google.secretMountAbsolutePath" . }}
{{- end }}
EVENT_BUS_PROJECT_ID: {{ .Values.cartoConfigValues.cartoAccGcpProjectId | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
LDS_ERROR_RESPONSE_STACK_TRACE: {{ .Values.cartoConfigValues.enableErrorResponseStackTrace | quote }}
LDS_PORT: {{ .Values.ldsApi.containerPorts.http | quote }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
{{- if .Values.appConfigValues.ldsGeocodingProvider }}
LDS_GEOCODING_PROVIDER: {{ .Values.appConfigValues.ldsGeocodingProvider }}
{{- end }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/maps-api/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ data:
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
EVENT_BUS_PROJECT_ID: {{ .Values.cartoConfigValues.cartoAccGcpProjectId | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
EXPORTS_GCS_BUCKET_NAME: {{ .Values.appConfigValues.workspaceExportsBucket | quote }}
Expand All @@ -35,7 +38,7 @@ data:
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
GOOGLE_APPLICATION_CREDENTIALS: {{ include "carto.google.secretMountAbsolutePath" . }}
{{- end }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
MAPS_API_V3_ERROR_RESPONSE_STACK_TRACE: {{ .Values.cartoConfigValues.enableErrorResponseStackTrace | quote }}
MAPS_API_V3_PORT: "{{ .Values.mapsApi.containerPorts.http }}"
MAPS_API_V3_RESOURCE_URL_ALLOWED_HOSTS: {{ .Values.appConfigValues.selfHostedDomain | quote }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/sql-worker/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,17 @@ data:
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
EXPORTS_GCS_BUCKET_NAME: {{ .Values.appConfigValues.workspaceExportsBucket | quote }}
EXPORTS_S3_BUCKET_NAME: {{ .Values.appConfigValues.awsExportBucket | quote }}
EXPORTS_S3_BUCKET_REGION: {{ .Values.appConfigValues.awsExportBucketRegion | quote }}
EXPORTS_S3_BUCKET_ROLE_ARN: {{ .Values.appConfigValues.exportAwsRoleArn | quote }}
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
GOOGLE_APPLICATION_CREDENTIALS: {{ include "carto.google.secretMountAbsolutePath" . }}
{{- end }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
MAPS_API_V3_COMPONENT_NAME: "sql-worker"
MAPS_API_V3_ERROR_RESPONSE_STACK_TRACE: {{ .Values.cartoConfigValues.enableErrorResponseStackTrace | quote }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/workspace-api/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ data:
{{- if .Values.replicated.enabled }}
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
EVENT_BUS_PROJECT_ID: {{ .Values.cartoConfigValues.cartoAccGcpProjectId | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
EXPORTS_GCS_BUCKET_NAME: {{ .Values.appConfigValues.workspaceExportsBucket | quote }}
{{- if not .Values.commonBackendServiceAccount.enableGCPWorkloadIdentity }}
GOOGLE_APPLICATION_CREDENTIALS: {{ include "carto.google.secretMountAbsolutePath" . }}
{{- end }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
NODE_OPTIONS: {{ template "carto.workspaceApi.nodeOptions" . }}
PUBSUB_MODE: "pull"
PUBSUB_PROJECT_ID: {{ .Values.cartoConfigValues.selfHostedGcpProjectId | quote }}
Expand Down
5 changes: 4 additions & 1 deletion chart/templates/workspace-subscriber/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ data:
{{- if .Values.replicated.enabled }}
CARTO_SELFHOSTED_REPLICATED_SDK_DOMAIN: "replicated.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:3000"
{{- end }}
{{- if eq .Values.appConfigValues.logLevel "debug" }}
CARTO_TRACING_MODE: "local"
{{- end }}
COMPUTE_PUBSUB_DATA_UPDATES_SUBSCRIPTION: "projects/{{ .Values.cartoConfigValues.selfHostedGcpProjectId }}/subscriptions/data-updates-compute-sub"
EVENT_BUS_PROJECT_ID: {{ .Values.cartoConfigValues.cartoAccGcpProjectId | quote }}
EVENT_BUS_TOPIC: "projects/{{ .Values.cartoConfigValues.cartoAccGcpProjectId }}/topics/{{ .Values.cartoConfigValues.cartoAccGcpProjectRegion }}-event-bus"
Expand All @@ -39,7 +42,7 @@ data:
{{- if and .Values.externalRedis.tlsEnabled .Values.externalRedis.tlsCA }}
REDIS_TLS_CA: {{ include "carto.redis.configMapMountAbsolutePath" . }}
{{- end }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
PUBSUB_DATA_UPDATES_TOPICS_TEMPLATE: "projects/{project_id}/topics/data-updates"
PUBSUB_MODE: "pull"
PUBSUB_PROJECT_ID: {{ .Values.cartoConfigValues.selfHostedGcpProjectId | quote }}
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/workspace-www/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ data:
REACT_APP_BIGQUERY_OAUTH: "false"
{{- end }}
CARTO_SELFHOSTED_VERSION: {{ .Chart.AppVersion | quote }}
LOG_LEVEL: "debug"
LOG_LEVEL: {{ .Values.appConfigValues.logLevel | quote }}
REACT_APP_ACCOUNTS_API_URL: "https://{{ .Values.cartoConfigValues.cartoAccApiDomain }}"
REACT_APP_ACCOUNTS_URL: "https://{{ .Values.appConfigValues.selfHostedDomain }}/acc/"
REACT_APP_API_BASE_URL: "https://{{ .Values.appConfigValues.selfHostedDomain }}/api"
Expand Down
2 changes: 2 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ appConfigValues:
ldsRoutingProvider: ""
## @param appConfigValues.ldsIsolineProvider The default LDS provider for isolines
ldsIsolineProvider: ""
## @param appConfigValues.logLevel The log level used in CARTO application
logLevel: "info"

## @section CARTO Replicated parameters
## Global configuration for installations using Replicated. If you change something from this section probably your self-hosted is going to stop working.
Expand Down
48 changes: 9 additions & 39 deletions manifests/kots-helm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,13 @@ spec:
## Values from Advanced Configuration
optionalValues:
## TEMPORAL PATCHED IMAGES
# - when: 'true'
# recursiveMerge: true
# values:
# routerMetrics:
# image:
# registry: registry.self-hosted.carto.com/proxy/carto/gcr.io/carto-artifacts
# tag: "latest"
- when: 'true'
recursiveMerge: true
values:
httpCache:
image:
registry: registry.self-hosted.carto.com/proxy/carto/gcr.io/carto-artifacts
tag: "feature_sc_457242_add_an_easier_approach_for_enabling_the_debug"
# httpCache:
# image:
# registry: registry.self-hosted.carto.com/proxy/carto/gcr.io/carto-artifacts
Expand Down Expand Up @@ -538,38 +538,8 @@ spec:
- when: '{{repl ConfigOptionEquals "enablePlatformDebugMode" "1" }}'
recursiveMerge: true
values:
httpCache:
extraEnvVars:
- name: VARNISH_LOG_LEVEL
value: "DEBUG"
importApi:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
importWorker:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
ldsApi:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
mapsApi:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
sqlWorker:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
workspaceApi:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
workspaceSubscriber:
extraEnvVars:
- name: CARTO_TRACING_MODE
value: "local"
appConfigValues:
logLevel: "debug"
## Openshift
- when: '{{repl ConfigOptionEquals "platformDistribution" "openShift" }}'
recursiveMerge: true
Expand Down

0 comments on commit 3bcd0e9

Please sign in to comment.