Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blockbuster to detect blocking calls #175

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Use blockbuster to detect blocking calls #175

merged 1 commit into from
Nov 27, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 25, 2024

No description provided.

@cbornet cbornet requested a review from hemidactylus November 25, 2024 12:48
@cbornet cbornet marked this pull request as draft November 25, 2024 14:28
@cbornet cbornet force-pushed the blockbuster branch 2 times, most recently from 380ba39 to 3f7a82d Compare November 25, 2024 17:05
@cbornet cbornet marked this pull request as ready for review November 25, 2024 17:05
@@ -612,10 +607,12 @@ async def aexecute_cql(
statement = SimpleStatement(final_cql)
logger.debug(f'aExecuting statement "{final_cql}" as simple (unprepared)')
else:
statement = self._obtain_prepared_statement(final_cql)
statement = await asyncio.to_thread(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's no possibility to prepare a statement async in the driver atm.
So delegating to a thread...

@cbornet cbornet force-pushed the blockbuster branch 3 times, most recently from 467a2ac to bcb3ad1 Compare November 25, 2024 17:14
Copy link
Collaborator

@hemidactylus hemidactylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, brilliant work!

@cbornet cbornet merged commit fc0c307 into main Nov 27, 2024
4 checks passed
@cbornet cbornet deleted the blockbuster branch November 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants