feat: translations extraction command #2045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new `translations:extract` command to facilitate extraction and processing of translation strings from layouts. Signed-off-by: Franck Matsos <[email protected]>
|
About static code analysis: I tried to resolve these problems. But without DI it's hard to decouple code properly, and I don't know what are the architecture choices about that. I didn't want to instantiate services manually for now (except for required classes from translation/twig components). |
|
Sorry, I swtich the PR to Draft as some unintended operations occured when I extracted translations this morning (it overwritten extraction file instead of update it, and some keys are missing). I fix that! 😄 |
|
Hello @fmatsos, thanks a lot for your contribution. Today I worked on some refactorings and I think the result is correct. I also simplified the options. Could you take a look please? Demo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in discussion #2034, I searched how to easily extract translations from layouts like any other Symfony based website. Since Cecil is build on Symfony components, and translation component is already included, I do this proposal largely inspired by the original CLI Symfony command.
Now we can extract translations from our layouts or theme layout, without need to use external tool or script.
Hope it'll be useful!