[WIP]: Powdr Input Deserialization #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass context and the reqest object to the powdr execution Serialize the expected params with cbor into new struct and add to pipeline
|
@CeciliaZ030 Could you have a look at this PR? |
CeciliaZ030
reviewed
Feb 26, 2024
| graffiti, | ||
| prover, | ||
| } = get_data_serde::<InputData>(42); |
There was a problem hiding this comment.
Have u figured out what does this number "42" mean? I'm asking cuz I don't really know so not sure if it will break when we actually run with real block.
There was a problem hiding this comment.
It's a channel on which the input is sent, so we add it here on the receiving and and it must match on the sending end here. I recommend we use a shared const somewhere in the code base so that this remains synced instead of being manually hardcoded
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves taikoxyz#37