Skip to content

Commit

Permalink
Fix presence of unsigned in a parameter signature resetting the type
Browse files Browse the repository at this point in the history
name being constructed. In the common case of using an unsigned
parameter this was typically harmless.

When unsigned was used as part of a template type parameter this would
overwrite the type info already built up, so:

   array<unsigned int>

would become:

   unsigned int>

The parameter types were being used only to generate the hash to pair
with whatever clscan generates. The side effect of which being, any
function that suffered from this problem would not have its call address
patched up.
  • Loading branch information
dwilliamson committed Jul 20, 2021
1 parent 56b1ce9 commit 7b314b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/clReflectExport/MapFileParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ namespace
// Check for any type prefixes
else if (!strcmp(token, "unsigned") || !strcmp(token, "signed"))
{
strcpy(type_name, token);
strcat(type_name, token);
strcat(type_name, " ");
}

Expand Down

0 comments on commit 7b314b9

Please sign in to comment.