-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RequestHeaders
property to Cesium3DTileset
#1581
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ede6c52
Add RequestHeaders property to Cesium3DTileset
azrogers b7e985a
Fix self-assignment
azrogers c21ebc6
Merge branch 'main' of github.com:CesiumGS/cesium-unreal into request…
azrogers 93a3060
Address review comments
azrogers 2187d31
Merge branch 'request-headers-tileset' of github.com:CesiumGS/cesium-…
azrogers 96cf605
Update cesium-native, format
azrogers 04b6a7d
Merge remote-tracking branch 'origin/main' into request-headers-tileset
kring b7ee99d
Merge with main
azrogers b9df7f1
Fix build with latest cesium-native
azrogers 6faa51f
Remove redundant GLM_ENABLE_EXPERIMENTAL
azrogers 1ed7f94
Merge branch 'glm-build-fix' of github.com:CesiumGS/cesium-unreal int…
azrogers f218a01
Merge branch 'request-headers-tileset' of github.com:CesiumGS/cesium-…
azrogers dbb4056
Remove redundant changelog entry.
kring a9476d7
CompareMaps -> MapsAreEqual, and move to anonymous namespace.
kring File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule cesium-native
updated
46 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in the anonymous namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also something like
MapsAreEqual
would be a better name thanCompareMaps
, because the latter doesn't indicate as clearly what it means when the function returns true or false.