Add UpdateTimeZoneFromLongitude to ACesiumSunSky
#1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azrogers
changed the title
UpdateTimeZoneFromLongitude to ACesiumSunSkyUpdateTimeZoneFromLongitude to ACesiumSunSky
|
@j9liu Incorporated those edits! |
|
Thanks @azrogers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1258. This PR adds a new method to
ACesiumSunSkythat updates theTimeZoneproperty based on the given longitude. This is calculation is based on the simple formula ofLongitudeInDegrees / 15.0, but this more or less approximates real time zones and when paired with solar time accomplishes the goal of "the sun should be at this position in the sky relative to the current location."UpdateTimeZoneFromLongitudecan be called at runtime, but this change also makes it so that clicking "Place Georeference Origin Here" will automatically update the time zone based on the new longitude, reducing friction for new users.