Skip to content

Commit

Permalink
Add TODOs for later changes
Browse files Browse the repository at this point in the history
  • Loading branch information
siddheshranade committed Jan 23, 2024
1 parent 6fb7752 commit df41480
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/actions/check-for-CLA/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ const PULL_REQUST_INFO = {
gitHubToken: process.env.GITHUB_TOKEN
};

/* TODO: Replace with actual Cesium spreadsheet Ids - these are test sheets that I'll delete, so okay to git push */
/* TODO: Then store in repo secrets */
/* TODO: 1. Replace with actual Cesium CLA spreadsheet Ids, 2. Retrieve Ids from GitHub Secrets, not expose */
const GOOGLE_SHEETS_INFO = {
individualCLASheetId: '1oRRS8OG4MfXaQ8uA4uWQWukaOqxEE3N-JuqzrqGGeaE',
corporateCLASheetId: '1dnoqifzpXB81G1V4bsVJYM3D19gXuwyVZZ-IgNgCkC8'
Expand Down Expand Up @@ -59,8 +58,7 @@ const checkIfUserHasSignedAnyCLA = async () => {

const getGoogleSheetsApiClient = async () => {
const auth = new google.auth.GoogleAuth({
// TODO: get from GitHub secrets
// (JSON contains keys for my personal Service account that isn't used for anything else, so okay to git push)
// TODO: 1. Get similar config file for Cesium Google account, 2. Retrive file from secrets and remove from source control
keyFile: 'TempGoogleConfig.json',
scopes: ['https://www.googleapis.com/auth/spreadsheets']
});
Expand Down Expand Up @@ -139,7 +137,7 @@ const postCommentOnPullRequest = async (hasSignedCLA, errorFoundOnCLACheck) => {
const getCommentBody = (hasSignedCLA, errorFoundOnCLACheck) => {
console.log('getting comment template...');

const commentTemplate = fs.readFileSync('./.github/actions/check-for-cla/templates/pullRequestComment.hbs', 'utf-8');
const commentTemplate = fs.readFileSync('./.github/actions/check-for-CLA/templates/pullRequestComment.hbs', 'utf-8');
const getTemplate = Handlebars.compile(commentTemplate);
const commentBody = getTemplate({
errorCla: errorFoundOnCLACheck,
Expand Down

0 comments on commit df41480

Please sign in to comment.