Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-spherical ellipsoid voxels #11654

Closed
wants to merge 60 commits into from
Closed

Support non-spherical ellipsoid voxels #11654

wants to merge 60 commits into from

Conversation

jjhembd
Copy link
Contributor

@jjhembd jjhembd commented Nov 27, 2023

Our preliminary implementation of the ellipsoid voxel shape depended on a few simplifying assumptions. Some of these assumptions broke down for non-spherical ellipsoids, introducing inaccuracies in places like:

  • Calculation of geodetic latitude.
  • Computing heights.

The errors were small on a global scale for nearly-spherical ellipsoids (like WGS84). But at smaller scales (<10km) the errors could be significant.

This PR improves the accuracy of ellipsoid math in the voxel shaders. Along the way, some of the code was simplified to remove rarely-used or redundant shader defines and improve shader readability.

Jeshurun Hembd added 30 commits July 11, 2023 19:23
@cesium-concierge
Copy link

Thanks for the pull request @jjhembd!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@jjhembd jjhembd marked this pull request as draft November 27, 2023 20:49
@jjhembd
Copy link
Contributor Author

jjhembd commented Feb 22, 2024

This mammoth PR has been superseded by several more focused PRs:

@jjhembd jjhembd closed this Feb 22, 2024
@jjhembd jjhembd deleted the ellipsoid-voxels branch April 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants