-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-spherical ellipsoid voxels #11654
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request @jjhembd!
Reviewers, don't forget to make sure that:
|
This mammoth PR has been superseded by several more focused PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our preliminary implementation of the ellipsoid voxel shape depended on a few simplifying assumptions. Some of these assumptions broke down for non-spherical ellipsoids, introducing inaccuracies in places like:
The errors were small on a global scale for nearly-spherical ellipsoids (like WGS84). But at smaller scales (<10km) the errors could be significant.
This PR improves the accuracy of ellipsoid math in the voxel shaders. Along the way, some of the code was simplified to remove rarely-used or redundant shader defines and improve shader readability.