Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default RequestsScheduler.maximumRequestsPerServer #11673

Merged
merged 3 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# Change Log

### 1.113
### 1.113 - 2024-01-02

#### @cesium/engine

##### Fixes :wrench:

- Changes the default `RequestScheduler.maximumRequestsPerServer` from 6 to 18. This should improve performance on HTTP/2 servers and above [#11627](https://github.com/CesiumGS/cesium/issues/11627)
- Corrected JSDoc and Typescript definitions that marked optional arguments as required in `ImageryProvider` constructor [#11625](https://github.com/CesiumGS/cesium/issues/11625)

### 1.112 - 2023-12-01
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
- [Jeshurun Hembd](https://github.com/jjhembd)
- [Mia Tang](https://github.com/miatang13)
- [Mark Dane](https://github.com/angrycat9000)
- [jjspace](https://github.com/jjspace)
- [Northrop Grumman](http://www.northropgrumman.com)
- [Joseph Stein](https://github.com/nahgrin)
- [EOX IT Services GmbH](https://eox.at)
Expand Down
12 changes: 3 additions & 9 deletions packages/engine/Source/Core/RequestScheduler.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ RequestScheduler.maximumRequests = 50;
* The maximum number of simultaneous active requests per server. Un-throttled requests or servers specifically
* listed in {@link requestsByServer} do not observe this limit.
* @type {number}
* @default 6
* @default 18
*/
RequestScheduler.maximumRequestsPerServer = 6;
RequestScheduler.maximumRequestsPerServer = 18;

/**
* A per server key list of overrides to use for throttling instead of <code>maximumRequestsPerServer</code>.
Expand All @@ -78,13 +78,7 @@ RequestScheduler.maximumRequestsPerServer = 6;
* "assets.cesium.com:443": 18,
* };
*/
RequestScheduler.requestsByServer = {
"api.cesium.com:443": 18,
"assets.ion.cesium.com:443": 18,
"ibasemaps-api.arcgis.com:443": 18,
"tile.googleapis.com:443": 18,
"tile.openstreetmap.org:443": 18,
};
RequestScheduler.requestsByServer = {};

/**
* Specifies if the request scheduler should throttle incoming requests, or let the browser queue requests under its control.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,11 @@ describe("Core/GoogleEarthEnterpriseTerrainProvider", function () {
const promises = [];
return pollToPromise(function () {
let b = true;
for (let i = 0; i < 10; ++i) {
for (
let i = 0;
i < RequestScheduler.maximumRequestsPerServer + 2;
++i
) {
b = b && terrainProvider.getTileDataAvailable(i, i, i);
}
return b && terrainProvider.getTileDataAvailable(1, 2, 3);
Expand Down