Fix Quaternion.computeAxis
#11684
Merged
Fix Quaternion.computeAxis
#11684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the x-axis as the result for the unit quaternion and for the quaternion that describes as rotation about 360 degrees.
|
(Not sure which parts of the build failures are related to this PR itself, but ... I assume ... none of them...) |
Huh. @javagl Would you mind merging in |
…nto fix-quaternion-compute-axis # Conflicts: # CHANGES.md
|
Not sure what happened here - I'm pretty sure that I branched off from |
|
@javagl The CI failure is fixed in #11689 (comment). I'm going to update the branch for you. |
|
Thanks @javagl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11665 :
Use the x-axis as the result for the unit quaternion and for the quaternion that describes as rotation about 360 degrees.