Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cla checking test 6 #11854

Closed
wants to merge 152 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
8e271f1
Add height references for 3D tiles
ggetz Nov 3, 2023
acf76ce
Merge branch 'tileset-get-height' into 3d-tiles-height-reference
ggetz Nov 3, 2023
38b6699
Merge branch 'tileset-get-height' into 3d-tiles-height-reference
ggetz Dec 7, 2023
3f35d9a
Tweak API, fix unit tests
ggetz Dec 14, 2023
4b1aaff
Merge branch 'tileset-get-height' into 3d-tiles-height-reference
ggetz Dec 14, 2023
4308e10
Update Sandcastle
ggetz Dec 14, 2023
6d7f114
Update Sandcastle
ggetz Dec 14, 2023
3e7adc9
Merge branch '3d-tiles-height-reference' of github.com:AnalyticalGrap…
ggetz Dec 14, 2023
d555f26
Simplify and document VoxelTraversal helper functions
Jan 2, 2024
8c645fd
Merge branch 'tileset-get-height' into 3d-tiles-height-reference
ggetz Jan 4, 2024
36f3e7a
Update model specs
ggetz Jan 4, 2024
4fd8c5b
Error -> DevloperError
ggetz Jan 4, 2024
890deff
Minor cleanup in picking code
Jan 7, 2024
30b5ee2
Find traversal tiles by megatextureId
Jan 7, 2024
d8b8e7e
Keep voxel metadata in memory for picking
Jan 7, 2024
d3a8739
Fix VoxelTraversal specs
Jan 8, 2024
3ddee4c
Add VoxelPicking and VoxelPickFramebuffer
Jan 10, 2024
20fd2be
Merge branch 'main' into 3d-tiles-height-reference
ggetz Jan 12, 2024
88eaa5f
WIP: begin implementing voxel picking pass
Jan 13, 2024
fe87380
Fix performance issue
ggetz Jan 16, 2024
d0c2721
PR feedback
ggetz Jan 16, 2024
9b95eac
Update packages/engine/Source/Scene/Cesium3DTileset.js
ggetz Jan 17, 2024
0d5607f
Update packages/engine/Source/Scene/Scene.js
ggetz Jan 17, 2024
9591d82
Fix comments
ggetz Jan 17, 2024
bcb793a
Fix crash when transitioning
ggetz Jan 17, 2024
d489a76
Update packages/engine/Source/Scene/Cesium3DTileset.js
ggetz Jan 17, 2024
0f819cf
Cleanup
ggetz Jan 19, 2024
cb0ec02
Merge branch '3d-tiles-height-reference' of github.com:AnalyticalGrap…
ggetz Jan 19, 2024
11251dd
Merge branch 'main' into 3d-tiles-height-reference
ggetz Jan 19, 2024
ba83221
PR feedback
Jan 22, 2024
23424f6
Add spec for VoxelTraversal.findKeyframeNode
Jan 22, 2024
a005c07
Merge pull request #11754 from CesiumGS/voxel-memory
ggetz Jan 22, 2024
63ede00
Return tile and sample index from Scene.pickVoxel
Jan 23, 2024
e84c822
Remove VoxelPickFramebuffer and VoxelPicking
Jan 24, 2024
4538d58
Fix voxel indices calculation
Jan 24, 2024
3e2f0b6
Merge branch 'voxel-picking' into voxel-pickbuffer
Jan 24, 2024
a4ee372
Fix VoxelTraversalSpec
Jan 24, 2024
41fcc70
Move voxel coordinate picking to private method
Jan 24, 2024
1a91e48
Clarify picking-related comments
Jan 25, 2024
b1fb022
Update async syntax in PickingSpec
Jan 25, 2024
386e020
Add spec for Scene._pickVoxelCoordinate
Jan 25, 2024
e716ff8
PR feedback round 2
Jan 26, 2024
eeddace
Add VoxelCell class and Scene.pickVoxel method
Jan 27, 2024
dd3f773
Merge branch 'main' into 3d-tiles-height-reference
ggetz Jan 29, 2024
d34938c
Fix #11787
ggetz Jan 29, 2024
86ceffb
Remove dead code
ggetz Jan 29, 2024
2b59f05
Merge pull request #11784 from CesiumGS/voxel-pickbuffer
ggetz Jan 29, 2024
fd4e8a6
add createWorldBathymetryAsync function
jjspace Jan 29, 2024
47cd8a0
add test
jjspace Jan 29, 2024
dbf74ff
update changes.md
jjspace Jan 29, 2024
b216c10
comment changes
jjspace Jan 30, 2024
4b5542d
Update approximateTerrainHeight.json
ggetz Jan 30, 2024
2dd276f
remove water mask option
jjspace Jan 30, 2024
33f768a
update the right function
jjspace Jan 30, 2024
6cbb679
Fix demodernizeShader to preserve parameter qualifiers
Jan 31, 2024
53fc51b
Update CHANGES.md
Jan 31, 2024
3e6f96f
Add specs for voxel picking, refactor private methods
Jan 31, 2024
4b38ee9
Merge branch 'voxel-picking' into voxel-pick-api
jjhembd Jan 31, 2024
41d8f6a
Remove PolygonGeometry.computeRectangle
Jan 31, 2024
eec24e8
Update npm dependencies
Jan 31, 2024
1ece49a
Merge pull request #11795 from CesiumGS/create-world-bathymetry
ggetz Jan 31, 2024
6b5d19a
Fix spec
ggetz Jan 31, 2024
edf7146
Merge pull request #11803 from CesiumGS/polygon-cleanup
jjspace Jan 31, 2024
9fdf399
Update zip.js dependency
Jan 31, 2024
e30f7b9
Merge remote-tracking branch 'origin/main' into cwb-terrain-heights
jjspace Jan 31, 2024
f73ff11
Fix markdown linting issues
Jan 31, 2024
b9da04d
Merge pull request #11804 from CesiumGS/feb-package-updates
ggetz Jan 31, 2024
8273efc
Merge pull request #11604 from CesiumGS/3d-tiles-height-reference
jjspace Jan 31, 2024
9326aaa
Merge branch 'main' into pick-model-performance
ggetz Feb 1, 2024
73c578b
Merge remote-tracking branch 'origin/main' into cwb-terrain-heights
jjspace Feb 1, 2024
176bd4e
Merge pull request #11792 from CesiumGS/pick-model-performance
jjspace Feb 1, 2024
f1c24c6
update spec and changes.md
jjspace Feb 1, 2024
8e59fbb
Merge pull request #11805 from CesiumGS/cwb-terrain-heights
ggetz Feb 1, 2024
e88b53f
Fix failing specs
Feb 1, 2024
ee11a1e
add missing sandcastle thumbnails, resize existing large ones
jjspace Feb 1, 2024
1dd2829
Merge pull request #11808 from CesiumGS/spec-fixes
jjspace Feb 1, 2024
9053cb9
Updates for 1.114 release
Feb 1, 2024
67f3ed4
Update ThirdParty.json
Feb 1, 2024
ffe5378
change question template to contact link
jjspace Feb 2, 2024
2ba6efa
Merge pull request #11809 from CesiumGS/update-sandcastle-images
ggetz Feb 2, 2024
f705ecf
update description
jjspace Feb 2, 2024
f30c70b
Merge pull request #11810 from CesiumGS/remove-question-template
ggetz Feb 2, 2024
d583580
Add link to release guide
ggetz Feb 5, 2024
57f0e15
Update CONTRIBUTORS.md
siddheshranade Feb 5, 2024
29e8259
Handle lost context in SceneSpec
Feb 6, 2024
0dbe7d0
Handle bad Cartesian data sooner
Feb 6, 2024
8f4472b
Merge branch 'main' into webgl1-parameter-qualifiers
Feb 6, 2024
d1ed5ba
PR feedback round 1
Feb 6, 2024
c6ce5aa
Merge pull request #11798 from CesiumGS/webgl1-parameter-qualifiers
ggetz Feb 6, 2024
418d8c0
Fix webgl stub for isContextLost check
Feb 7, 2024
0f4f1a7
Use new scene for each test in SceneSpec
Feb 7, 2024
8586e8b
Fix Camera.flyHome in 2D on Firefox
Feb 7, 2024
c42e172
Eliminate duplicate createScene calls
Feb 7, 2024
78fbcd2
Use async/await in SceneSpec
Feb 7, 2024
a47c95e
Merge pull request #11815 from CesiumGS/flaky-specs
jjspace Feb 7, 2024
2e3f609
Merge branch 'main' into voxel-pick-api
Feb 8, 2024
1526a73
Merge branch 'main' into voxel-picking
Feb 8, 2024
42a67fb
Merge branch 'voxel-picking' into voxel-pick-api
Feb 8, 2024
196d692
Add default matcher for pickVoxel specs
Feb 8, 2024
703385f
Add voxel tile and sample indices to FragmentInput struct
Feb 6, 2024
762c95a
Expose tile bounding box from VoxelCell
Feb 6, 2024
79c7bc2
Expose sample bounding box from VoxelCell
Feb 7, 2024
d22cca8
Add VoxelCell.fromKeyframeNode factory function
Feb 7, 2024
451d514
Update processVoxelPropertiesSpec
Feb 7, 2024
fcf0873
Add specs for VoxelShape computeOrientedBoundingBoxForSample methods
Feb 9, 2024
8dd282e
Add VoxelCellSpec
Feb 9, 2024
c5d71ec
Update gltf-pipeline files
javagl Feb 12, 2024
5fc20d5
Fix axis conversion matrix definitions
javagl Feb 12, 2024
8984beb
Return early from pickVoxel if tile has been discarded
Feb 13, 2024
d133b10
PR feedback round 3
Feb 13, 2024
de7ee92
Merge pull request #11800 from CesiumGS/voxel-pick-api
ggetz Feb 13, 2024
53d834f
Merge pull request #11826 from CesiumGS/fix-constant-matrices
ggetz Feb 13, 2024
ddd4999
Update CHANGES.md
javagl Feb 13, 2024
c0c0d78
Update CHANGES.md
Feb 13, 2024
21a7cfb
Merge pull request #11825 from CesiumGS/gltf-pipeline-2024-02-12
ggetz Feb 14, 2024
e441d1c
Adjust defaults for 3D Tiles collisions
ggetz Feb 14, 2024
e685557
Default parameter
ggetz Feb 14, 2024
9986e88
Pull out voxel longitude calculations
Feb 15, 2024
5e1dabe
Consolidate longitude ranges in voxel intersections
Feb 15, 2024
76bc304
Consolidate voxel longitude and latitude ranges
Feb 16, 2024
4068348
Assume minimum height in VoxelEllipsoidShape
Feb 16, 2024
009f2aa
Simplify handling of thin cylindrical voxels
Feb 16, 2024
ed0a321
Update power plant tileset asset ID
lilleyse Feb 17, 2024
a4bbf5e
Updated Viewer.destory to check for screenSpaceEventHandler
huffmantayler Feb 19, 2024
7c1b011
Updated contributors
huffmantayler Feb 19, 2024
5a856ba
Merge pull request #11839 from CesiumGS/update-power-plant-tileset
ggetz Feb 19, 2024
6c9318c
Updated destroy function with recommended check of screenSpaceEventHa…
huffmantayler Feb 19, 2024
d595c90
Updated changes.md
huffmantayler Feb 19, 2024
ca7a8b8
PR feedback round 4
Feb 19, 2024
b14c1d4
Update CHANGES.md
ggetz Feb 19, 2024
1f9116e
Merge pull request #11828 from CesiumGS/voxel-picking
ggetz Feb 19, 2024
1974ff4
Merge pull request #11840 from huffmantayler/destroy_event_handler
ggetz Feb 19, 2024
fb2d9ab
Merge branch 'main' into collision-default
ggetz Feb 19, 2024
aa73207
Simplify height bounds in VoxelEllipsoidShape
Feb 19, 2024
41195e6
Attempting a fix for empty tile refinement issues.
weegeekps Feb 20, 2024
975d846
Removed a line of dead code.
weegeekps Feb 20, 2024
a44a6a4
Code review changes.
weegeekps Feb 20, 2024
a76d1a7
updating Camera.changed to account for changes in roll
malaretv Feb 21, 2024
8443490
Update CHANGES.md
malaretv Feb 21, 2024
7cafdfa
Adjust specs, update CHANGES.md
ggetz Feb 21, 2024
2964ebf
executeEmptyTraversal implicit tweak
ggetz Feb 21, 2024
e59578b
Clarify logic in voxel longitude intersections
Feb 21, 2024
ab0aba2
Merge branch 'empty-refinement' of github.com:CesiumGS/cesium into em…
weegeekps Feb 21, 2024
a6b291f
Merge pull request #11829 from CesiumGS/collision-default
jjspace Feb 21, 2024
af4c693
Removed redundant line in CHANGES.md
weegeekps Feb 21, 2024
b4615ec
Removed the checks for empty leaves
weegeekps Feb 21, 2024
598f942
remove early return
malaretv Feb 21, 2024
ca88d4e
explicitly intialize _changedRoll in camera constructor
malaretv Feb 21, 2024
8ed89db
Merge pull request #11838 from CesiumGS/voxel-cleanup
ggetz Feb 22, 2024
1d0bf7b
Merge pull request #11843 from CesiumGS/empty-refinement
ggetz Feb 23, 2024
ba6f5a3
Merge pull request #11844 from malaretv/camera-changed-roll
ggetz Feb 23, 2024
aa9d459
Do not merge - cla checking test
siddheshranade Feb 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: Ask a question
url: https://community.cesium.com/c/cesiumjs/5
about: CesiumJS is a big project, so we use GitHub for feature requests and bug tracking exclusively. Please use the community forum for general questions. The Cesium team and community actively monitor it and love seeing what people are working on!
15 changes: 0 additions & 15 deletions .github/ISSUE_TEMPLATE/question.yaml

This file was deleted.

51 changes: 31 additions & 20 deletions Apps/SampleData/ClampToGround.czml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"clock": {
"interval": "2018-07-19T15:18:00Z/2018-07-19T15:18:30Z",
"currentTime": "2018-07-19T15:18:00Z",
"multiplier": 5,
"multiplier": 2,
"range": "LOOP_STOP",
"step": "SYSTEM_CLOCK_MULTIPLIER"
}
Expand All @@ -19,14 +19,22 @@
"interpolationAlgorithm": "LINEAR",
"forwardExtrapolationType": "HOLD",
"cartesian": [
"2018-07-19T15:18:00Z",
1216348.1632364073,
-4736348.958775471,
4081284.5528982095,
"2018-07-19T15:18:00Z",
1216327.3893347275,
-4736164.778028102,
4081507.5209477833,
"2018-07-19T15:18:10Z",
1216369.543258349,
-4736201.237448179,
4081447.3732212726,
"2018-07-19T15:18:20Z",
1216434.7507773656,
-4736241.372142024,
4081386.1802605274,
"2018-07-19T15:18:30Z",
1216369.1229444197,
-4736377.467107148,
4081240.888485707
1216525.7792628652,
-4736271.927759278,
4081319.744558958
]
},
"orientation": {
Expand All @@ -43,26 +51,29 @@
"polyline": {
"positions": {
"cartesian": [
1216348.1632364073,
-4736348.958775471,
4081284.5528982095,
1216369.1229444197,
-4736377.467107148,
4081240.888485707
1216327.3893347275,
-4736164.778028102,
4081507.5209477833,
1216369.543258349,
-4736201.237448179,
4081447.3732212726,
1216434.7507773656,
-4736241.372142024,
4081386.1802605274,
1216525.7792628652,
-4736271.927759278,
4081319.744558958
]
},
"material": {
"polylineOutline": {
"color": {
"rgba": [255, 255, 0, 255]
"rgba": [100, 149, 237, 140]
},
"outlineColor": {
"rgba": [0, 0, 0, 255]
},
"outlineWidth": 2
"outlineWidth": 0
}
},
"width": 10,
"width": 12,
"clampToGround": true
}
}
Expand Down
Binary file modified Apps/Sandcastle/gallery/3D Tiles 1.1 Photogrammetry.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion Apps/Sandcastle/gallery/3D Tiles BIM.html
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
}

try {
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(1240402);
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(2464651);
scene.primitives.add(tileset);

viewer.zoomTo(
Expand Down
2 changes: 1 addition & 1 deletion Apps/Sandcastle/gallery/3D Tiles Clipping Planes.html
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
}

// Power Plant design model provided by Bentley Systems
const bimUrl = Cesium.IonResource.fromAssetId(1240402);
const bimUrl = Cesium.IonResource.fromAssetId(2464651);
const pointCloudUrl = Cesium.IonResource.fromAssetId(16421);
const instancedUrl =
"../../SampleData/Cesium3DTiles/Instanced/InstancedOrientation/tileset.json";
Expand Down
4 changes: 1 addition & 3 deletions Apps/Sandcastle/gallery/3D Tiles Interior.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@
const viewer = new Cesium.Viewer("cesiumContainer");

try {
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(125737, {
disableCollision: true,
});
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(125737);
viewer.scene.primitives.add(tileset);
} catch (error) {
console.log(`Error loading tileset: ${error}`);
Expand Down
Binary file modified Apps/Sandcastle/gallery/3D Tiles Vertical Exaggeration.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion Apps/Sandcastle/gallery/Ambient Occlusion.html
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@

try {
// Power Plant design model provided by Bentley Systems
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(1240402);
const tileset = await Cesium.Cesium3DTileset.fromIonAssetId(2464651);
viewer.scene.primitives.add(tileset);
} catch (error) {
console.log(`Error loading tileset: ${error}`);
Expand Down
Loading
Loading