Skip to content

Commit

Permalink
Update the binary to use import vs require
Browse files Browse the repository at this point in the history
  • Loading branch information
nazarhussain committed Jan 7, 2025
1 parent 3547301 commit 21d022a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/benchmark-compare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ jobs:
uses: ChainSafe/benchmark/.github/workflows/compare-js-runtimes.yml@nh/compare
with:
node-version: 22
node-options: --loader ts-node/esm
bun-version: latest
deno-version: v2.x
command: ./bin/index.js
command: src/cli/cli.ts
setup: build
files: test/perf/**/*.test.ts

6 changes: 5 additions & 1 deletion .github/workflows/compare-js-runtimes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ on:
type: string
description: Nodejs version
required: true
node-options:
type: string
description: Extra options to run with the node, useful when using different loaders
required: false
bun-version:
type: string
description: Bun version, if specified will be used in comparison
Expand Down Expand Up @@ -47,7 +51,7 @@ jobs:
run: ${{ inputs.setup }}

- name: Run performance tests on node
run: node ${{ inputs.command }} ${{ inputs.files }} --local ./nodejs-benchmark --persist --noThrow ${{ github.event_name == 'push' }}
run: node ${{ inputs.node-options }} ${{ inputs.command }} ${{ inputs.files }} --local ./nodejs-benchmark --persist --noThrow ${{ github.event_name == 'push' }}

- name: Archive nodejs benchmark artifacts
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 21d022a

Please sign in to comment.