fix: deployment network type and naming #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeroBurny
reviewed
Jan 19, 2024
packages/plugin/src/utils.ts
Outdated
| @@ -49,7 +49,7 @@ export function sumedFees(fees: Numbers[]): string { | |||
| return sumOfFees.toString(); | |||
| } | |||
|
|
|||
| export function mapNetworkArgs<Abi extends ContractAbi = any>( | |||
| export function validateNetworkArgs<Abi extends ContractAbi = any>( | |||
There was a problem hiding this comment.
name is misleading as it validates and returns configuration...
can you separate these 2 duties?
There was a problem hiding this comment.
Your right, formatArgs would make sense, as it formats NetworkArguments for contract method.
And throws error if network key is different from type DeploymentNetwork.
There was a problem hiding this comment.
For me separate doesn't make much sense when we don't have config to validate now. It's only params is deployMultichain. And this loop
Object.keys(networkArgs).map((networkName) =>
should be only called once in deployMultichain
I could do 2 smaller helper func inside this, formatConstructorArgs and formatInitDatas?
BeroBurny
approved these changes
Jan 31, 2024
Merged
BeroBurny
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>hardhat-plugin-multichain-deploy: 1.0.0</summary> ## 1.0.0 (2024-02-16) ### Features * adapter address env ([#25](#25)) ([628a99c](628a99c)) * deploy multichain bytecode ([#22](#22)) ([2eff1ee](2eff1ee)) * encode constructor improve ([#24](#24)) ([9c4b7b1](9c4b7b1)) * encode function and deployMultichain flow ([#14](#14)) ([26229cf](26229cf)) * encodeInitData ([#30](#30)) ([50758ca](50758ca)) * example ([#49](#49)) ([637d0ae](637d0ae)) * initLocalEnvironment ([#47](#47)) ([e728a10](e728a10)) * rework networks input ([#23](#23)) ([3caf657](3caf657)) * tool interfaces aka fasad ([#10](#10)) ([6351819](6351819)) * transaction details and deployment info ([#33](#33)) ([2b3232d](2b3232d)) ### Bug Fixes * deployment network type and naming ([#26](#26)) ([1060069](1060069)) * small logical mistakes ([#48](#48)) ([6cfd609](6cfd609)) </details> <details><summary>hardhat-plugin-multichain-deploy-contracts: 1.0.0</summary> ## 1.0.0 (2024-02-16) ### Features * add contracts implementation ([#11](#11)) ([114c05f](114c05f)) * example ([#49](#49)) ([637d0ae](637d0ae)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.