Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax BitArray#intersectValues types #339

Merged
merged 3 commits into from
Feb 10, 2024
Merged

fix: relax BitArray#intersectValues types #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d26fab
fix: relax BitArray#intersectValues types
wemeetagain Feb 9, 2024
c1ee571
chore: update ci
wemeetagain Feb 9, 2024
54489fc
chore: update ci
wemeetagain Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:

steps:
- uses: actions/checkout@v3
- run: corepack enable
- uses: actions/setup-node@v3
with:
cache: yarn
node-version: 18
- run: corepack enable
- run: yarn --immutable && yarn build

- name: Run benchmarks
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jobs:
node: [16, 18]
steps:
- uses: actions/checkout@v3
- run: corepack enable
- uses: actions/setup-node@v3
with:
node-version: ${{matrix.node}}
cache: yarn
- run: corepack enable
- name: Bootstrap
run: yarn --immutable
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion packages/ssz/src/value/bitArray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class BitArray {
/**
* Returns an array with the indexes which have a bit set to true
*/
intersectValues<T>(values: T[]): T[] {
intersectValues<T>(values: ArrayLike<T>): T[] {
const yes: T[] = [];

if (values.length !== this.bitLen) {
Expand Down
Loading