Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Toggle chain sample when you switch back to the original chain with Metamask on WebGL #1262 #1263

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

creeppak
Copy link
Contributor

@creeppak creeppak commented Dec 16, 2024

  • Moved "SwitchChainAddIfMissing" logic to be used in Reown only.
  • Switching chains the old simple way for all the Wallet Providers by default.

A new bug related to Reown was discovered. You can't switch chains in Reown as exception is getting thrown. It also happens in dev.

The error:

MissingMethodException: Constructor on type 'ChainSafe.Gaming.Reown.Methods.WalletAddEthereumChain' not found.

Reverted previous SwitchChain implementation to be used by default for all the WalletProviders
# Conflicts:
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/IWalletProvider.cs
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/WalletProvider.cs
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/WalletSigner.cs
@creeppak creeppak marked this pull request as draft December 16, 2024 15:48
@creeppak creeppak marked this pull request as ready for review December 17, 2024 15:09
Copy link
Collaborator

@rob1997 rob1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! however this could conflict with #1270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants