Added opening a user's chat in a new tab/split/window with keybinds+click

CHANGELOG.md

@@ -11,6 +11,7 @@
 - Minor: Added chatter count for each category in viewer list. (#3683)
 - Minor: Sorted usernames in /vips message to be case-insensitive. (#3696)
 - Minor: Added option to open a user's chat in a new tab from the usercard profile picture context menu. (#3625)
+- Minor: Added option to open a user's chat in a new tab/split/window by CTRL/ALT/SHIFT+Left Clicking (#3766)
 - Minor: Fixed tag parsing for consecutive escaped characters. (#3711)
 - Minor: Prevent user from entering incorrect characters in Live Notifications channels list. (#3715, #3730)
 - Minor: Fixed automod caught message notice appearing twice for mods. (#3717)

src/controllers/commands/CommandController.cpp

@@ -742,15 +742,7 @@ void CommandController::initialize(Settings &, Paths &paths)
             return "";
         }
 
-        auto *app = getApp();
-        Window &window = app->windows->createWindow(WindowType::Popup, true);
-
-        auto *split = new Split(static_cast<SplitContainer *>(
-            window.getNotebook().getOrAddSelectedPage()));
-
-        split->setChannel(app->twitch->getOrAddChannel(target));
-
-        window.getNotebook().getOrAddSelectedPage()->appendSplit(split);
+        getApp()->windows->openNewChannelWindow(target);
 
         return "";
     });

src/singletons/WindowManager.cpp

@@ -275,6 +275,22 @@ Window &WindowManager::createWindow(WindowType type, bool show)
     return *window;
 }
 
+Window &WindowManager::openNewChannelWindow(ChannelPtr channel)
+{
+    Window &window = this->createWindow(WindowType::Popup, true);
+    auto split =
+        window.getNotebook().getOrAddSelectedPage()->appendNewSplit(false);
+    split->setChannel(channel);
+    window.getNotebook().getOrAddSelectedPage()->refreshTab();
+    return window;
+}
+
+Window &WindowManager::openNewChannelWindow(QString channelName)
+{
+    return this->openNewChannelWindow(
+        getApp()->twitch->getOrAddChannel(channelName));
+}
+
 void WindowManager::select(Split *split)
 {
     this->selectSplit.invoke(split);

src/singletons/WindowManager.hpp

@@ -59,6 +59,10 @@ class WindowManager final : public Singleton
     Window &getSelectedWindow();
     Window &createWindow(WindowType type, bool show = true);
 
+    // Opens a channel in new popup window
+    Window &openNewChannelWindow(ChannelPtr channel);
+    Window &openNewChannelWindow(QString channelName);
+
     void select(Split *split);
     void select(SplitContainer *container);
 

src/widgets/dialogs/UserInfoPopup.cpp

@@ -295,14 +295,8 @@ UserInfoPopup::UserInfoPopup(bool closeAutomatically, QWidget *parent)
                         menu->addAction(
                             "Open channel in a new popup window", this,
                             [loginName] {
-                                auto app = getApp();
-                                auto &window = app->windows->createWindow(
-                                    WindowType::Popup, true);
-                                auto split = window.getNotebook()
-                                                 .getOrAddSelectedPage()
-                                                 ->appendNewSplit(false);
-                                split->setChannel(app->twitch->getOrAddChannel(
-                                    loginName.toLower()));
+                                getApp()->windows->openNewChannelWindow(
+                                    loginName);
                             });
 
                         menu->addAction(

src/widgets/helper/ChannelView.cpp

@@ -2187,8 +2187,25 @@ void ChannelView::handleLinkClick(QMouseEvent *event, const Link &link,
     {
         case Link::UserWhisper:
         case Link::UserInfo: {
-            auto user = link.value;
-            this->showUserInfoPopup(user, layout->getMessage()->channelName);
+            switch (event->modifiers())
+            {
+                case Qt::ShiftModifier:
+                    getApp()->windows->openNewChannelWindow(link.value);
+                    break;
+                case Qt::ControlModifier:
+                    this->openChannelIn.invoke(
+                        link.value, FromTwitchLinkOpenChannelIn::Tab);
+                    break;
+                case Qt::AltModifier:
+                    this->openChannelIn.invoke(
+                        link.value, FromTwitchLinkOpenChannelIn::Split);
+                    break;
+                default:
+                    auto user = link.value;
+                    this->showUserInfoPopup(user,
+                                            layout->getMessage()->channelName);
+                    break;
+            }
         }
         break;
 

src/widgets/splits/Split.cpp

@@ -874,18 +874,11 @@ void Split::explainSplitting()
 
 void Split::popup()
 {
-    auto app = getApp();
-    Window &window = app->windows->createWindow(WindowType::Popup);
-
-    Split *split = new Split(static_cast<SplitContainer *>(
-        window.getNotebook().getOrAddSelectedPage()));
-
-    split->setChannel(this->getIndirectChannel());
+    Window &window = getApp()->windows->openNewChannelWindow(
+        this->getIndirectChannel().get());
+    Split *split = window.getNotebook().getOrAddSelectedPage()->getSplits()[0];
     split->setModerationMode(this->getModerationMode());
     split->setFilters(this->getFilters());
-
-    window.getNotebook().getOrAddSelectedPage()->appendSplit(split);
-    window.show();
 }
 
 void Split::clear()