Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: prevent unnecessary layouts at leaveEvent #4879

Merged
merged 3 commits into from
Feb 25, 2024
Merged

perf: prevent unnecessary layouts at leaveEvent #4879

merged 3 commits into from
Feb 25, 2024

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Oct 9, 2023

Currently ChannelView::leaveEvent triggers 2 layouts every time mouse leaves.

  • ChannelView::unpause now returns if channelview was not paused
  • removed unnecessary queueLayout, i didnt find practical use to force it here, tested for 1h with no issues

pajlada
pajlada approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected, can let nightly users test it some more

@pajlada pajlada changed the title Perf: prevent unnecessary layouts at leaveEvent perf: prevent unnecessary layouts at leaveEvent Feb 25, 2024
@pajlada pajlada enabled auto-merge (squash) February 25, 2024 11:54
@pajlada pajlada merged commit 1e2c943 into Chatterino:master Feb 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornes @pajlada @Felanbird