Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed some compiler warnings #5028

Merged
merged 11 commits into from
Dec 16, 2023
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 15, 2023

Description

I couldn't bear the warnings anymore. The first commits are the most important, as they remove the most spammy warnings. Each commit fixes one category of warnings.

Working towards #4825.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/Label.cpp Outdated Show resolved Hide resolved
src/widgets/Label.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/SettingsPage.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/SettingsPage.cpp Outdated Show resolved Hide resolved
@pajlada pajlada changed the title fix: Reduce warnings when compiling with MSVC fix: Fixed some compiler warnings Dec 16, 2023
@pajlada pajlada enabled auto-merge (squash) December 16, 2023 11:02
@pajlada pajlada merged commit 66f4480 into Chatterino:master Dec 16, 2023
18 of 20 checks passed
@Nerixyz Nerixyz deleted the fix/misc-warnings branch December 16, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants