chore: keep GDI fontengine on Windows for now #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Nov 12, 2024
pajlada
reviewed
Nov 12, 2024
Co-authored-by: pajlada <[email protected]>
pajlada
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #5694: The DirectWrite font engine in Qt 6.8.0 doesn't match the behavior of the old GDI engine. As explained in #5694 (comment), I filed QTBUG-130861, but that won't be fixed until at least 6.8.2 (most likely - 6.8.1 is to be released on 21st of November). The issue doesn't affect the default configuration on Windows that uses Segoe UI as it has a style for the 600 weight. Only fonts that don't have a style for the 600 weight are affected.
Currently, we don't gain much by using DirectWrite exclusively (note the DirectWrite is already used for some fonts that require it - it's also used in the linked issue), so I disabled that fontengine by default. Users can still opt-out by disabling
CHATTERINO_USE_GDI_FONTENGINE.I also removed the
dpiawareness=2as this was never read, because the key was wrong (WindowArgumentshad thesinWindowsmissing).