-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retrieve ddo claims #12
Conversation
Signed-off-by: Miroslav Bajtoš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 💪🏻
backend/package.json
Outdated
"pg": "^8.13.1", | ||
"slug": "^10.0.0" | ||
"request": "^2.88.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikolasHaimerl please remove this line (the unused dependency).
backend/package.json
Outdated
"slug": "^10.0.0" | ||
"request": "^2.88.2", | ||
"slug": "^10.0.0", | ||
"undici": "^7.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikolasHaimerl please remove this line (the unused dependency).
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the loop iterating over multiple epochs is written correctly, see https://github.com/filecoin-station/deal-observer/pull/12/files#r1928634351
Other than that, the pull request looks great now! 👌🏻
No further review is necessary as far as I am concerned, merge at will.
I believe I committed your code suggestion. Which is why the comment was resolved. But I see that the loop is incorrect. I"ll fix that. |
Co-authored-by: Miroslav Bajtoš <[email protected]>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This MR proposes the following changes
Context: We are using the glif api to retrieve data from Filecoin. In Filecoin built in actors are responsible for managing and updating the global state of the filecoin network.
DDO (Direct Data Oboarding) in FIL+ deals bypass the usually used StorageActor and oboard data directly. The actor which registers the oboarded data is the verified registry actor (Source).
For spark to be aware of these deals we need to listen to the events emmitted by this actor and look for deals with certain properties (new deals, updated deals,...).
The glif api allows for the fetching of raw built-in Actorevents. The returned data needs to be processed, extracted and then parsed into the correct actor event type.
In this PR the parsing of the ClaimEvent type is being implemented. A sample data point of how the fetched data (after some preprocessing) might look like is stored in
test_data
. Here, we test that the data can be successfully parsed by the transformer and a class object of the type ClaimEvent can be retrieved for further use.This implementation is inspired by an existing prototype for fetching build in actor events.
See issue.