Minor changes to support Windows install. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ztangent! |
|
I have patched @ztangent, could you try it out and let me know if it works? I don't have access to a Windows machine to test it on. |
|
Yup, it's working now! :) ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to install
genparselocally on my Windows computer, I ran into a couple of issues following the installation instructions in the README. This PR fixes those issues by:utf-8in the call toopeninsetup.pyvllmwhen runningmake envon a Windows computer (sincevllmdoesn't support Windows, and I was running into issues trying to install it).Installation was successful after I made the fixes above. However, I still ran into issues when loading the
arsenalpackage, because of the following error:AttributeError: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'?(Apparently Windows does not support
signal.SIGALRM, which is required byarsenal.robust.)I also haven't tested if this will cause issues for Linux and Mac builds, but I thought I'd just make this PR since it was a quick fix --- if it's a bother, feel free to ignore it!