Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vllm integration #14

Merged
merged 37 commits into from
Jun 24, 2024
Merged

Vllm integration #14

merged 37 commits into from
Jun 24, 2024

Conversation

lyutyuh
Copy link
Collaborator

@lyutyuh lyutyuh commented Jun 20, 2024

No description provided.

@lyutyuh lyutyuh requested a review from timvieira June 20, 2024 13:31
@lyutyuh
Copy link
Collaborator Author

lyutyuh commented Jun 20, 2024

#10

@benlebrun benlebrun self-requested a review June 20, 2024 16:24
@benlebrun
Copy link
Collaborator

hey @lyutyuh, this looks great, though I think you need to add vllm to the dependencies, since all of the tests are failing. You can run make test to confirm that all the tests pass. I can handle the merge conflicts with the proposals.

@lyutyuh
Copy link
Collaborator Author

lyutyuh commented Jun 23, 2024

steering methods rewritten for vllm: vllm_steer.py

@timvieira timvieira merged commit 2024f78 into main Jun 24, 2024
4 checks passed
@timvieira timvieira deleted the vllm branch June 29, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants