Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move tx endpoint into wallet-specific code #19116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move tx endpoint into wallet-specific code #19116

wants to merge 1 commit into from
+198 −211

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 9, 2025

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 9, 2025
@altendky altendky marked this pull request as ready for review January 9, 2025 19:42
@altendky altendky requested a review from a team as a code owner January 9, 2025 19:42
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 12696864743

Details

  • 86 of 86 (100.0%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.509%
Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/daemon/client.py 1 74.72%
chia/timelord/timelord_launcher.py 1 91.43%
chia/full_node/full_node_api.py 2 84.77%
chia/server/node_discovery.py 3 81.14%
chia/rpc/rpc_server.py 3 88.54%
chia/full_node/full_node.py 7 86.08%
chia/wallet/wallet_node.py 9 87.74%
chia/_tests/core/util/test_lockfile.py 24 77.31%
Totals Coverage Status
Change from base Build 12691593511: -0.04%
Covered Lines: 105299
Relevant Lines: 114892
💛 - Coveralls

@altendky altendky requested a review from emlowe January 9, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quexington Quexington Quexington approved these changes

@emlowe emlowe Awaiting requested review from emlowe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @Quexington