Skip to content

Commit

Permalink
Update to CEF 122.1.10+gc902316+chromium-122.0.6261.112
Browse files Browse the repository at this point in the history
Frame identifiers change from long to String.
  • Loading branch information
S1artie authored and magreenblatt committed Mar 7, 2024
1 parent e75a3c0 commit 0b8e42e
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 52 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ set_property(GLOBAL PROPERTY OS_FOLDERS ON)

# Specify the CEF distribution version.
if(NOT DEFINED CEF_VERSION)
set(CEF_VERSION "121.3.9+g1e0a38f+chromium-121.0.6167.184")
set(CEF_VERSION "122.1.10+gc902316+chromium-122.0.6261.112")
endif()

# Determine the platform.
Expand Down
6 changes: 3 additions & 3 deletions java/org/cef/browser/CefBrowser.java
Original file line number Diff line number Diff line change
Expand Up @@ -125,20 +125,20 @@ public interface CefBrowser {
* @param identifier The unique frame identifier
* @return The frame or NULL if not found
*/
public CefFrame getFrame(long identifier);
public CefFrame getFrameByIdentifier(String identifier);

/**
* Returns the frame with the specified name, or NULL if not found.
* @param name The specified name
* @return The frame or NULL if not found
*/
public CefFrame getFrame(String name);
public CefFrame getFrameByName(String name);

/**
* Returns the identifiers of all existing frames.
* @return All identifiers of existing frames.
*/
public Vector<Long> getFrameIdentifiers();
public Vector<String> getFrameIdentifiers();

/**
* Returns the names of all existing frames.
Expand Down
16 changes: 8 additions & 8 deletions java/org/cef/browser/CefBrowser_N.java
Original file line number Diff line number Diff line change
Expand Up @@ -351,27 +351,27 @@ public CefFrame getFocusedFrame() {
}

@Override
public CefFrame getFrame(long identifier) {
public CefFrame getFrameByIdentifier(String identifier) {
try {
return N_GetFrame(identifier);
return N_GetFrameByIdentifier(identifier);
} catch (UnsatisfiedLinkError ule) {
ule.printStackTrace();
return null;
}
}

@Override
public CefFrame getFrame(String name) {
public CefFrame getFrameByName(String name) {
try {
return N_GetFrame2(name);
return N_GetFrameByName(name);
} catch (UnsatisfiedLinkError ule) {
ule.printStackTrace();
return null;
}
}

@Override
public Vector<Long> getFrameIdentifiers() {
public Vector<String> getFrameIdentifiers() {
try {
return N_GetFrameIdentifiers();
} catch (UnsatisfiedLinkError ule) {
Expand Down Expand Up @@ -839,9 +839,9 @@ private final native CefRegistration N_AddDevToolsMessageObserver(
private final native int N_GetIdentifier();
private final native CefFrame N_GetMainFrame();
private final native CefFrame N_GetFocusedFrame();
private final native CefFrame N_GetFrame(long identifier);
private final native CefFrame N_GetFrame2(String name);
private final native Vector<Long> N_GetFrameIdentifiers();
private final native CefFrame N_GetFrameByIdentifier(String identifier);
private final native CefFrame N_GetFrameByName(String name);
private final native Vector<String> N_GetFrameIdentifiers();
private final native Vector<String> N_GetFrameNames();
private final native int N_GetFrameCount();
private final native boolean N_IsPopup();
Expand Down
4 changes: 2 additions & 2 deletions java/org/cef/browser/CefFrame.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ public interface CefFrame {
void dispose();

/**
* Returns the globally unique identifier for this frame or < 0 if the
* Returns the globally unique identifier for this frame or an empty string if the
* underlying frame does not yet exist.
* @return The frame identifier
*/
long getIdentifier();
String getIdentifier();

/**
* Emits the URL currently loaded in this frame.
Expand Down
6 changes: 3 additions & 3 deletions java/org/cef/browser/CefFrame_N.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ public void dispose() {
}

@Override
public long getIdentifier() {
public String getIdentifier() {
try {
return N_GetIdentifier(getNativeRef(null));
} catch (UnsatisfiedLinkError ule) {
ule.printStackTrace();
return -1;
return null;
}
}

Expand Down Expand Up @@ -157,7 +157,7 @@ public void selectAll() {
}

private final native void N_Dispose(long self);
private final native long N_GetIdentifier(long self);
private final native String N_GetIdentifier(long self);
private final native String N_GetURL(long self);
private final native String N_GetName(long self);
private final native boolean N_IsMain(long self);
Expand Down
36 changes: 11 additions & 25 deletions native/CefBrowser_N.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1086,21 +1086,6 @@ void OnAfterParentChanged(CefRefPtr<CefBrowser> browser) {
}
}

jobject NewJNILongVector(JNIEnv* env, const std::vector<int64_t>& vals) {
ScopedJNIObjectLocal jvector(env, "java/util/Vector");
if (!jvector)
return nullptr;

std::vector<int64_t>::const_iterator iter;
for (iter = vals.begin(); iter != vals.end(); ++iter) {
ScopedJNIObjectLocal argument(
env, NewJNIObject(env, "java/lang/Long", "(J)V", (jlong)*iter));
JNI_CALL_VOID_METHOD(env, jvector, "addElement", "(Ljava/lang/Object;)V",
argument.get());
}
return jvector.Release();
}

CefPdfPrintSettings GetJNIPdfPrintSettings(JNIEnv* env, jobject obj) {
CefString tmp;
CefPdfPrintSettings settings;
Expand Down Expand Up @@ -1369,23 +1354,24 @@ Java_org_cef_browser_CefBrowser_1N_N_1GetFocusedFrame(JNIEnv* env,
}

JNIEXPORT jobject JNICALL
Java_org_cef_browser_CefBrowser_1N_N_1GetFrame(JNIEnv* env,
jobject obj,
jlong identifier) {
Java_org_cef_browser_CefBrowser_1N_N_1GetFrameByIdentifier(JNIEnv* env,
jobject obj,
jstring identifier) {
CefRefPtr<CefBrowser> browser = JNI_GET_BROWSER_OR_RETURN(env, obj, nullptr);
CefRefPtr<CefFrame> frame = browser->GetFrame(identifier);
CefRefPtr<CefFrame> frame =
browser->GetFrameByIdentifier(GetJNIString(env, identifier));
if (!frame)
return nullptr;
ScopedJNIFrame jframe(env, frame);
return jframe.Release();
}

JNIEXPORT jobject JNICALL
Java_org_cef_browser_CefBrowser_1N_N_1GetFrame2(JNIEnv* env,
jobject obj,
jstring name) {
Java_org_cef_browser_CefBrowser_1N_N_1GetFrameByName(JNIEnv* env,
jobject obj,
jstring name) {
CefRefPtr<CefBrowser> browser = JNI_GET_BROWSER_OR_RETURN(env, obj, nullptr);
CefRefPtr<CefFrame> frame = browser->GetFrame(GetJNIString(env, name));
CefRefPtr<CefFrame> frame = browser->GetFrameByName(GetJNIString(env, name));
if (!frame)
return nullptr;
ScopedJNIFrame jframe(env, frame);
Expand All @@ -1402,9 +1388,9 @@ JNIEXPORT jobject JNICALL
Java_org_cef_browser_CefBrowser_1N_N_1GetFrameIdentifiers(JNIEnv* env,
jobject obj) {
CefRefPtr<CefBrowser> browser = JNI_GET_BROWSER_OR_RETURN(env, obj, nullptr);
std::vector<int64_t> identifiers;
std::vector<CefString> identifiers;
browser->GetFrameIdentifiers(identifiers);
return NewJNILongVector(env, identifiers);
return NewJNIStringVector(env, identifiers);
}

JNIEXPORT jobject JNICALL
Expand Down
12 changes: 7 additions & 5 deletions native/CefBrowser_N.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions native/CefFrame_N.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ JNIEXPORT void JNICALL Java_org_cef_browser_CefFrame_1N_N_1Dispose(JNIEnv* env,
ClearSelf(env, obj);
}

JNIEXPORT jlong JNICALL
JNIEXPORT jstring JNICALL
Java_org_cef_browser_CefFrame_1N_N_1GetIdentifier(JNIEnv* env,
jobject obj,
jlong self) {
CefRefPtr<CefFrame> frame = GetSelf(self);
if (!frame)
return (jlong)-1;
return (jlong)frame->GetIdentifier();
return nullptr;
return NewJNIString(env, frame->GetIdentifier());
}

JNIEXPORT jstring JNICALL
Expand Down
4 changes: 2 additions & 2 deletions native/CefFrame_N.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0b8e42e

Please sign in to comment.