237 edit profile picture and name

[mikozet]

Closes #421

[llunaCreixent]

note that the user data cannot be updated until the Safe is deployed and signed up to the Hub

[mikozet]

note that the user data cannot be updated until the Safe is deployed and signed up to the Hub

Thanks for reminding. That case is covered by redirection - if safe is not deployed user will end up on /welcome, /validation pages so I guess we are fine here

[llunaCreixent]

I was testing in local dev env, and just after registering (in validation view), The username wasn't there, and instead the safeAddress. Then after I refreshed, I was able to see my username in the validation view.

[mikozet]

Hey @llunaCreixent yes we have this registered as an issue here: #421

[llunaCreixent]

Looks good!! But I added com comments

• ✅ Tests: PASS
• ✅ Lint: didn't pass but I added a commit

[llunaCreixent]

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

[llunaCreixent]

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

That is what I check in the API side: https://github.com/CirclesUBI/circles-api/blob/c68f5b483fd46101394a5fef60e959ad29341659/src/controllers/users.js#L92

But maybe it's ok if it's not in the frontend. MAybe ask @triaslucia ??

[llunaCreixent]

Shall we add in the Description of this PR, "Closes #421" ??

[JacqueGM]

approved now for real, functionality works!

[mikozet]

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

I created issue for that:
CirclesUBI/circles-core#135

[mikozet]

no let's leave it I need to test it and probably add a little additional code in one place..
It will come in next PR when I add email ...