Show contractors Employing Company+Allow alt titles

[MarsM0nd]

About The Pull Request

This fixes that contractor IDs (The faction not being NT ones, not the Traveler title) do show which other company they are employed by. At the same time, it allows them to use alternative titles for the jobs.

Why It's Good For The Game

Showing which company someone belongs to on the ID was intended, and did just break. Alternative titles were explicitly disabled, due to confusing titles coming with some factions, but as there no longer are any, we can allow the full range of known station alternatives. A Vey-Med nurse probably should stay a nurse, and not become a full doctor when working at an NT station, at least title wise, as example.

Changelog

🆑
tweak: Allows contractors to have alt-titles
fix: Contractor IDs show the employing company
/:cl:

[TheLordME]

Contractor dont get Alt-titles because certain lore contributors gave their company specific alt-titles nobody understands. That is why Alt titles disapear when you are a contractor

[MarsM0nd]

#6531 did remove all of the alternative titles (which were part of necropolis and the naramid guilds), so currently, it's not required. I didn't fully remove it, just comment out the parts to indicate that it should stick to station default names.
As alternatives, either a list needs to be made for the default titles/no-default titles, to assign the rank instead, or a full refactor so the alt_title prototype gets handed there, being able to check if the background is set. The background handling could also be removed in code\modules\jobs\alt_title.dm and the hooks for it from code\modules\jobs\job.dm, to make it more likely such won't get added in the future.

[TheLordME]

ah, carry on then