HKSID-270: fix project managers permissions #325
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saijaseppa
commented
Feb 20, 2025
| const projectGroup = groups.find(({ id }) => id === project.projectGroup); | ||
| if (data.projectClass !== projectGroup?.classRelation) { | ||
| data = { ...data, "projectGroup": null } | ||
| } |
There was a problem hiding this comment.
This is only refactoring.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is still a draft. Waiting for refactoring for isInputDisabled (make a list of denied fields in form, and pass that list to components using isInputDisabled).
Description
Project manager is not allowed to delete projects.
Also fixed permission to fields budgetOverRun (forbidden), projectQualityLevel (allowed), planningPhase (allowed) and constructionPhase (allowed).
Ticket: https://futurice.atlassian.net/jira/software/c/projects/HKISD/boards/62?selectedIssue=HKISD-270
Related PR in backend: City-of-Helsinki/infraohjelmointi-api#245
Testing
Set the roles in backend: in file BaseViewSet.py modify the permission_classes so that it includes only the projectManager role. In frontend: in file AuthSlice.ts uncomment from the ad_groups the projectManager group. This will simulate the case when user has only projectManager role.