Feature/pgov 487 order metrics by date #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… View, as they are complex, underused and D11 incompatible
…t in use & not D11 compatible
…Indicator entites are loaded
…Indicator entites are loaded
…_date' into feature/PGOV-487-Order_metrics_by_date # Conflicts: # web/modules/custom/pgov_indicator/pgov_indicator.module
…l_11_Preflight Drupal 11 Preflight acabouet#1
…Indicator entites are loaded
…_date' into feature/PGOV-487-Order_metrics_by_date
|
@acabouet This is a low-impact change (sits on an entity_load and doesn't directly change data) It's also a prerequisite to adding the json array of measurements to Indicators, as we'll use the module that's getting set up here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards getting the indicator/measurement data in a usable format by ensuring that the values are ordered sequentially.
I had originally intended to effect this on the migration, but using an entity_load removes that burden and will make this self-healing.
Testing:
Compare: https://pgov-cms.app.cloud.gov/node/2146/edit?destination=/admin/content
Editing a performance indicator on the live site:
Editing the same after enabling the module, on this branch:
