Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: Add 404 check when creating add to cart url for single … #227

Merged
merged 1 commit into from
May 2, 2020
Merged

Security fix: Add 404 check when creating add to cart url for single … #227

merged 1 commit into from
May 2, 2020

Conversation

timbocode
Copy link
Contributor

@timbocode timbocode commented Feb 27, 2020

…products

Backport from woocommerce/woocommerce@dc1438d

See also #214

This PR also covers the following commits:

WC commits badb135 and f7a5449 are identical.

WC commit dc1438d includes the changes made in the above two commits as well as other changes, making badb135 and f7a5449 superfluous.

Files changed

includes/class-wc-product-simple.php

@timbocode timbocode added the Security Security fixes including WC backports label Feb 27, 2020
@timbocode timbocode added this to the 1.0.0-beta1 milestone Feb 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #227 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
- Coverage     40.82%   40.82%   -0.01%     
- Complexity    13447    13451       +4     
============================================
  Files           367      367              
  Lines         51277    51282       +5     
============================================
  Hits          20936    20936              
- Misses        30341    30346       +5
Impacted Files Coverage Δ Complexity Δ
includes/class-wc-product-simple.php 42.1% <0%> (-15.04%) 15 <0> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ee48...b83c68d. Read the comment docs.

@timbocode
Copy link
Contributor Author

Testing

  • Manually checked adding single product to cart.

@timbocode timbocode requested a review from nylen March 13, 2020 13:20
@bahiirwa bahiirwa self-requested a review May 1, 2020 13:32
Copy link
Collaborator

@bahiirwa bahiirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar manual test done to add products to cart and there are no hiccups as a manual user. Purchase process is executed well. No admin issues seen either.

@timbocode timbocode removed the request for review from nylen May 2, 2020 10:34
@timbocode timbocode merged commit e47c0c3 into ClassicPress:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security fixes including WC backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants