Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: Exit after redirect in wc-user-functions.php #228

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Security fix: Exit after redirect in wc-user-functions.php #228

merged 1 commit into from
Mar 7, 2020

Conversation

timbocode
Copy link
Contributor

@timbocode timbocode commented Feb 28, 2020

Backport for WC woocommerce/woocommerce@293d16f

Also covers woocommerce/woocommerce@4d6ddf3, a duplicate of the above.

See also #214.

Files changed

includes/wc-user-functions.php
(function wc_disable_author_archives_for_customers()).

@timbocode timbocode added the Security Security fixes including WC backports label Feb 28, 2020
@timbocode timbocode added this to the 1.0.0-beta1 milestone Feb 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #228 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #228      +/-   ##
============================================
+ Coverage     40.82%   40.83%   +<.01%     
  Complexity    13447    13447              
============================================
  Files           367      367              
  Lines         51277    51278       +1     
============================================
+ Hits          20936    20937       +1     
  Misses        30341    30341
Impacted Files Coverage Δ Complexity Δ
includes/wc-user-functions.php 80.48% <0%> (-0.29%) 0 <0> (ø)
includes/class-wc-tax.php 79.67% <0%> (+0.27%) 130% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ee48...c647bc3. Read the comment docs.

@bahiirwa
Copy link
Collaborator

bahiirwa commented Mar 6, 2020

This is a safe change if reference is done with wp_safe_redirect

@timbocode timbocode merged commit dd3c619 into ClassicPress:master Mar 7, 2020
@timbocode timbocode requested a review from nylen March 8, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security fixes including WC backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants